Expose basis choice in n3fit runcard

[scarlehoff]

As discussed in #593 it would be a nice feature to have.

[Zaharid]

This is closely related to #559, which should be done first.

[scarlehoff]

Agreed on the priority order, but let me highlight that code-wise they should be perpendicular... So one person can help in one topic and a different person on the other topic!

[Zaharid]

I don't think so. We already have all sorts of functionality for dealing with bases in runcards and I wouldn't want that to be reinvented for no reason.

…

On Mon, Oct 21, 2019 at 5:52 PM Juacrumar ***@***.***> wrote: Agreed on the priority order, but let me highlight that code-wise they should be perpendicular... So one person can help in one topic and a different person on the other topic! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#602?email_source=notifications&email_token=ABLJWUXY3BPHBQMUDQCZFULQPXM6TA5CNFSM4JC5EK22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB3ASJQ#issuecomment-544606502>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABLJWUQAIOAAHB3VXOTKSCLQPXM6TANCNFSM4JC5EK2Q> .

[scarlehoff]

But n3fit needs to know about it when generating the layer.

Basically the pdfNN_layer_generator function needs to receive a basis flag that will go into the Rotation layer.

Now, what does the rotation layer do with this flag is what #559 but having the flag allows you to have a "None" option which basically skips the rotation and then you fit directly in whatever basis is the input to your given fktable.

In summary: dealing with the flag is one thing (#559) having the flag is a different thing.

I agree with you about the priority order though, as at the code stands right now the user has to be the one making sure the last layer of the NN is in sync with the basis being used while the correct thing would be to chose a basis and then the last layer of the NN and the rotation are automatically filled.

In any case, help wanted in both issues!

[scarlehoff]

This was done by @tgiani in #749