Use .json file for tests#1041
Merged
Merged
Conversation
Member
Author
|
Added the reviewers for #1035 since they are "related" |
siranipour
approved these changes
Jan 13, 2021
Co-authored-by: siranipour <43517072+siranipour@users.noreply.github.com>
scarlehoff
force-pushed
the
test_use_json
branch
from
d350f2f to
22671c3
Compare
Member
Author
|
(rebased to avoid the error with hypothesis) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since now we have a
.jsonfile with all the information from the fit, I thought it made sense to use this instead of the "legacy files" in order to do a regression test.Since the
.fitinfofile in particular is still being used by validphys (and postfit), the test also ensures that the information in the.fitinfofile and the.jsonfile is the same.Finally, I added a second regression test since replica 1 doesn't pass the positivity veto so that we have one that passes (replica 2) (and therefore stops early) and one that doesn't. The double one is only ran in Linux, in Mac I'm running only replica 1, since the fit takes x3 in travis.