Skip to content

Build for Python 3.8#1047

Merged
scarrazza merged 9 commits into
masterfrom
py38
Mar 3, 2021
Merged

Build for Python 3.8#1047
scarrazza merged 9 commits into
masterfrom
py38

Conversation

@Zaharid
Copy link
Copy Markdown
Contributor

@Zaharid Zaharid commented Jan 11, 2021

I have added the external recipes
https://github.com/Zaharid/conda-recipes/
to use Github actions and build for python 3.8 and 3.9

and have updated reportengine to be python and os independet and also use github actions

https://github.com/NNPDF/reportengine/

with that we should be able to build for python 3.8. Of course for some reason it only works with new versions of conda build so this #915 needs to be addressed.

Python 3.9 should be trivial except that you-know-which-package is still missing support for it.

@Zaharid Zaharid changed the title Build for Pythob 3.8 Build for Python 3.8 Jan 11, 2021
@siranipour
Copy link
Copy Markdown
Contributor

Will this have affected anything yet? Just wondering if the reason some of my PRs fail here but not locally could be because of this

@Zaharid
Copy link
Copy Markdown
Contributor Author

Zaharid commented Jan 12, 2021

There is an unrelated general failure due to hypothesis deciding you have to touch some test. Would be nice to have a fix for that.

@Zaharid
Copy link
Copy Markdown
Contributor Author

Zaharid commented Jan 12, 2021

I think the mac conflict boils down to https://anaconda.org/anaconda/tensorflow-eigen being an old package for mac and maybe something else but it is genuinely impossible to understand what the problem is looking at the conda error. I would have thought it would be better at reporting errors than this :(.

Anyhow could someone try

~ $ conda create -p /tmp/testenv python=3.8 tensorflow-eigen

on mac?

@wilsonmr
Copy link
Copy Markdown
Contributor

As you say, that package doesn't appear to exist for 3.8.

$ conda create -p /tmp/testenv python=3.8 tensorflow-eigen
Collecting package metadata (current_repodata.json): done
Solving environment: failed with repodata from current_repodata.json, will retry with next repodata source.
Collecting package metadata (repodata.json): done
Solving environment: | 
Found conflicts! Looking for incompatible packages.
This can take several minutes.  Press CTRL-C to abort.
failed                                                                          

UnsatisfiableError: The following specifications were found to be incompatible with each other:

Output in format: Requested package -> Available versions

Package python conflicts for:
tensorflow-eigen -> tensorflow==2.0.0 -> python[version='2.7.*|3.7.*|3.6.*|>=3.6,<3.7.0a0|>=3.7,<3.8.0a0|>=2.7,<2.8.0a0|3.5.*|>=3.5,<3.6.0a0']
python=3.8


@Zaharid
Copy link
Copy Markdown
Contributor Author

Zaharid commented Feb 18, 2021

This does indeed work now. I have to clean it up a bit.

@scarrazza scarrazza merged commit d790599 into master Mar 3, 2021
@scarrazza scarrazza deleted the py38 branch March 3, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants