Show version information in vp reports by RosalynLP · Pull Request #1070 · NNPDF/nnpdf

RosalynLP · 2021-01-25T13:44:32Z

Closes #1066.

RosalynLP · 2021-01-25T14:49:41Z

To do:

Check that all replicas have same version info
Return "undefined" for fits without version info
Add action to vp-comparefits

siranipour · 2021-01-25T15:26:06Z

+    version_info = []
+    # First check if first replica has 'version.info'
+    p_1 = replica_paths[0]  / ('version.info')
+    if not p_1.is_file():


Are you checking if the file exists here? Perhaps p_1.exists() reads a bit more naturally if so

scarlehoff · 2021-01-26T08:31:20Z

Hi @RosalynLP, instead from the version.info file you should get the information from the .json file. It is somewhat newer and thus older fits (older meaning months) won't have it, but going forward I think all vp actions should get the information from the fit.json file (so that all the others, including fitinfo, can be removed).

Edit: A fit that contains this .json file is NNPDF40_nnlo_as_0118.

RosalynLP · 2021-01-26T09:37:50Z

Thanks @scarlehoff, will do - yep I didn't see these before as I was looking at an older fit.

github-actions · 2021-01-27T20:09:52Z

Greetings from your nice fit 🤖 !
I have good news for you, I just finished my tasks:

Fit Name: NNBOT-e662ce21-2021-01-27
Fit Report: https://vp.nnpdf.science/TSoIFgNYRb-GfvGv-R89Xg==
Fit Data: https://data.nnpdf.science/fits/NNBOT-e662ce21-2021-01-27.tar.gz

Check the report carefully, and please buy me a ☕ , or better, a GPU 😉!

github-actions · 2021-01-27T22:46:35Z

Greetings from your nice fit 🤖 !
I have good news for you, I just finished my tasks:

Fit Name: NNBOT-b7b0873d-2021-01-27
Fit Report: https://vp.nnpdf.science/ABbdki8gTVqoqtrl3NAJTQ==
Fit Data: https://data.nnpdf.science/fits/NNBOT-b7b0873d-2021-01-27.tar.gz

Check the report carefully, and please buy me a ☕ , or better, a GPU 😉!

RosalynLP · 2021-01-28T08:28:51Z

You can see at the bottom of the report what the version table looks like ... it's OK but personally I think it could be altered a little to look nicer - anyone else have an opinion?

scarlehoff · 2021-01-28T08:39:07Z

Ideally I would have three columns: name of the program, version of current, version of reference but don't know how difficult it is with vp (and I don't think it is a table we will be look at a lot)

RosalynLP · 2021-01-28T08:42:23Z

Ideally I would have three columns: name of the program, version of current, version of reference but don't know how difficult it is with vp (and I don't think it is a table we will be look at a lot)

The reason I didn't do that is because I also wanted the option to just return the info for one fit only. But I could do two actions, one for just one fit and one (to go in the vp report) with both fits combined.

scarlehoff · 2021-01-28T08:43:59Z

Ah, makes sense. For me it's ok like this (the only thing I would remove is the index number from the first column I guess).

RosalynLP · 2021-01-28T09:06:50Z

Yep I agree it's ugly and unnecessary

Zaharid · 2021-01-28T09:23:50Z

Ideally I would have three columns: name of the program, version of current, version of reference but don't know how difficult it is with vp (and I don't think it is a table we will be look at a lot)

Very easy. Have a look at how collect works (as applied to e.g. the fit summary among many things).

RosalynLP · 2021-01-28T09:47:53Z

Ideally I would have three columns: name of the program, version of current, version of reference but don't know how difficult it is with vp (and I don't think it is a table we will be look at a lot)

Very easy. Have a look at how collect works (as applied to e.g. the fit summary among many things).

Yes my plan was to do one joint table and one separate table so there are options

RosalynLP · 2021-01-29T13:28:39Z

OK I think the output is much nicer now:

Zaharid · 2021-01-29T13:41:51Z

As an aside, please delete all "4.0" fits from everywhere. And consider burning the computers where they were installed as an additional safety measure. CC @scarlehoff .

scarlehoff · 2021-01-29T13:47:03Z

No problem

wrt to the current output for the versions, I like it.

RosalynLP · 2021-01-29T13:49:05Z

As an aside, please delete all "4.0" fits from everywhere. And consider burning the computers where they were installed as an additional safety measure. CC @scarlehoff .

yeah don't worry I just installed them for this because they had version information

Co-authored-by: siranipour <43517072+siranipour@users.noreply.github.com>

Co-authored-by: Cameron Voisey <32741139+voisey@users.noreply.github.com>

RosalynLP · 2021-02-17T10:31:41Z

The checks pass now so can we merge this at the code call today?

Zaharid · 2021-02-17T12:11:10Z

I thought this was merged already. @voisey @siranipour please approce and merge asap.

Co-authored-by: Cameron Voisey <32741139+voisey@users.noreply.github.com>

Co-authored-by: siranipour <43517072+siranipour@users.noreply.github.com>

RosalynLP · 2021-02-18T09:33:35Z

Shall I merge?

siranipour · 2021-02-18T11:04:56Z

Yep good to go!!

RosalynLP added 2 commits January 25, 2021 13:43

initial version return

78b0e57

returning table

46caf22

check that version.info files exist

f8421a7

siranipour reviewed Jan 25, 2021

View reviewed changes

RosalynLP added 2 commits January 25, 2021 15:26

asserting version info matches

013a356

use exists rather than is_file

62e908d

RosalynLP added 2 commits January 26, 2021 09:51

use json rather than version.info files

d55d022

adding to vp report

675f9a9

Zaharid reviewed Jan 26, 2021

View reviewed changes

Comment thread validphys2/src/validphys/comparefittemplates/report.md Outdated

moving location in vp report

0676b00

RosalynLP marked this pull request as ready for review January 27, 2021 15:18

RosalynLP added the run-fit-bot Starts fit bot from a PR. label Jan 27, 2021

siranipour added run-fit-bot Starts fit bot from a PR. and removed run-fit-bot Starts fit bot from a PR. labels Jan 27, 2021

siranipour reviewed Jan 28, 2021

View reviewed changes

Comment thread validphys2/src/validphys/fitdata.py Outdated

making grouped table for vp reports

6285da4

siranipour reviewed Feb 9, 2021

View reviewed changes

Comment thread validphys2/src/validphys/fitdata.py Outdated

Comment thread validphys2/src/validphys/fitdata.py Outdated

Comment thread validphys2/src/validphys/fitdata.py Outdated

voisey reviewed Feb 10, 2021

View reviewed changes

Comment thread validphys2/src/validphys/fitdata.py Outdated

RosalynLP commented Feb 16, 2021

View reviewed changes

Comment thread validphys2/src/validphys/fitdata.py Outdated

RosalynLP and others added 3 commits February 16, 2021 15:59

remove json from replica files

6f2493c

add space

c4a2958

Co-authored-by: siranipour <43517072+siranipour@users.noreply.github.com>

typo

3016cad

Co-authored-by: Cameron Voisey <32741139+voisey@users.noreply.github.com>

voisey reviewed Feb 17, 2021

View reviewed changes

Comment thread validphys2/src/validphys/fitdata.py Outdated

Comment thread validphys2/src/validphys/fitdata.py Outdated

voisey reviewed Feb 17, 2021

View reviewed changes

Comment thread validphys2/src/validphys/fitdata.py

Update validphys2/src/validphys/fitdata.py

ab7ef4e

Co-authored-by: Cameron Voisey <32741139+voisey@users.noreply.github.com>

RosalynLP commented Feb 17, 2021

View reviewed changes

Comment thread validphys2/src/validphys/fitdata.py

add to docstring

c23fec5

RosalynLP commented Feb 17, 2021

View reviewed changes

Comment thread validphys2/src/validphys/fitdata.py Outdated

RosalynLP and others added 4 commits February 17, 2021 13:24

don't collect over fitcontext

97c2c32

move lines outside if/else block

4511f48

Merge branch 'version_info' of github.com:NNPDF/nnpdf into version_info

599fb78

fix bug & change set reduction

17bd589

siranipour reviewed Feb 17, 2021

View reviewed changes

Comment thread validphys2/src/validphys/fitdata.py Outdated

remove import

16b7500

Co-authored-by: siranipour <43517072+siranipour@users.noreply.github.com>

voisey approved these changes Feb 17, 2021

View reviewed changes

RosalynLP merged commit 5439f8e into master Feb 18, 2021

RosalynLP deleted the version_info branch February 18, 2021 11:22

Zaharid mentioned this pull request Mar 12, 2021

Have a fixed environment for paper #1126

Closed

Zaharid mentioned this pull request Aug 3, 2021

Adding action to bundle PDFs #1340

Merged

Conversation

RosalynLP commented Jan 25, 2021 • edited by Zaharid Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RosalynLP commented Jan 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

siranipour Jan 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

scarlehoff commented Jan 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RosalynLP commented Jan 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jan 27, 2021

Uh oh!

github-actions Bot commented Jan 27, 2021

Uh oh!

RosalynLP commented Jan 28, 2021

Uh oh!

scarlehoff commented Jan 28, 2021

Uh oh!

RosalynLP commented Jan 28, 2021

Uh oh!

scarlehoff commented Jan 28, 2021

Uh oh!

RosalynLP commented Jan 28, 2021

Uh oh!

Zaharid commented Jan 28, 2021

Uh oh!

RosalynLP commented Jan 28, 2021

Uh oh!

Uh oh!

RosalynLP commented Jan 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zaharid commented Jan 29, 2021

Uh oh!

scarlehoff commented Jan 29, 2021

Uh oh!

RosalynLP commented Jan 29, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RosalynLP commented Feb 17, 2021

Uh oh!

Zaharid commented Feb 17, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RosalynLP commented Feb 18, 2021

Uh oh!

siranipour commented Feb 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

RosalynLP commented Jan 25, 2021 •

edited by Zaharid

Loading

RosalynLP commented Jan 25, 2021 •

edited

Loading

siranipour Jan 25, 2021 •

edited

Loading

scarlehoff commented Jan 26, 2021 •

edited

Loading

RosalynLP commented Jan 26, 2021 •

edited

Loading

RosalynLP commented Jan 29, 2021 •

edited

Loading