Update mc_gen_checks module for C++ rep gen to data keyword

[RosalynLP]

I realise this is semi redundant given #866 but I was using this module to generate C++ replicas to compare to the python ones and had to update it to account for the data keyword changes. If people think this is worth merging we can do that.

[RosalynLP]

NB I've checked that the example runcard mc_gen_checks_example.yaml all works fine

[Zaharid]

Looks good!

[RosalynLP]

I'm not sure exactly what tests would be good for this module... because the actions deal with random numbers then you can't really check the output is unchanged. Could someone please help me with suggesting what is suitable?

[siranipour]

Would a regression test like in 6a12bd6 make sense? Just generate some pseudo data, save to disk and make sure we generate the same pseudo data if we seed appropriately until the end of time?

[RosalynLP]

Would a regression test like in 6a12bd6 make sense? Just generate some pseudo data, save to disk and make sure we generate the same pseudo data if we seed appropriately until the end of time?

ok I see, so a seed specific test

[siranipour]

Why is the test using the parquet pull request from report engine @Zaharid

[siranipour]

Btw could we call this file mc_gen.py?

[RosalynLP]

Btw could we call this file mc_gen.py?

Yeah no idea why it's called what it is!

[RosalynLP]

@siranipour lol thanks XD

[RosalynLP]

@Zaharid the build has errored and I can't restart it - is this something to do with the changes in reportengine or is it unrelated?

[Zaharid]

It looks reportengine related. Should be fixed now.

[siranipour]

I still can't get the job to restart. This must be a travis problem? We could try force pushing