NEW Restructure python data IO/actions#1098
Merged
Merged
Conversation
…ons, promoting preexisting functions to actions
wilsonmr
requested review from
RosalynLP,
Zaharid,
scarlehoff and
siranipour
Contributor
|
Sorry for not reviewing yet! I will get round to it soon I promise |
Contributor
|
FWIW I am fine with this split. |
RosalynLP
approved these changes
Feb 22, 2021
Contributor
RosalynLP
left a comment
RosalynLP
left a comment
There was a problem hiding this comment.
I like this layout - it's a simpler restructuring but groups things well, and also the new docs are very helpful.
| from validphys.api import API | ||
| from validphys.commondataparser import load_commondata | ||
| inp = { | ||
| "dataset_input": {"dataset":"NMC"}, |
Contributor
There was a problem hiding this comment.
Can we try an example with cfacs here?
scarlehoff
reviewed
Feb 22, 2021
Contributor
|
Is it worth updating the docstrings to use the API instead? |
Co-authored-by: Rosalyn Pearson <33020850+RosalynLP@users.noreply.github.com>
…fication and updated docstrings to recommend API
Contributor
Author
|
OK So I updated docstrings to use API and I also changed a couple of examples in the docs to use more complicated dataset settings to emphasize that not all datasets are like NMC, I didn't completely remove the NMC examples because I thought it was nice to have variety. |
Contributor
|
Is it me or the code is starting to look good? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supercedes #1080 but I left that open just in case.
here I implemented: #1080 (comment)
in addition to that I decided to just make the functions which built covmats into actions which meant we could get rid of unneccessary rubbish, in a similar manner to @siranipour's idea with #866 (simply changing the signature). I may have broken something along the way.
I think this is a good balance between not having unneccessary subdir but also it's slightly clearer where things should be