Conversation
Seems to me it is better to track this here instead of some random comment or the wiki.
Zaharid
requested review from
RosalynLP,
RoyStegeman,
enocera,
scarlehoff,
scarrazza,
siranipour,
tgiani,
voisey and
wilsonmr
scarlehoff
approved these changes
May 27, 2021
Member
scarlehoff
left a comment
scarlehoff
left a comment
There was a problem hiding this comment.
Tried it with some of the runcards I use locally to benchmark and seems to run ok.
Contributor
Author
|
Please test the new one. |
Member
|
Seems to be the exactly same in terms of memory, CPU time and results so I see no problems with it. |
Member
|
@Zaharid I believe this can be merged, right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems to me it is better to track this here instead of some random
comment or the wiki.
Closes #1126.
To (re)create the environment, please safe the environment file with a yaml extension and run