Conversation
Contributor
Author
|
Okay this wasn't actually the problem I now realise. The reason for the crash in #1285 is actually because the t0_prediction is an np scalar, will edit this commit |
siranipour
force-pushed
the
atleast1d
branch
5 times, most recently
from
6b57cce to
cc7604d
Compare
Contributor
Author
|
I've added a test that fails on master with the same error message as #1285 |
added 2 commits
June 28, 2021 14:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This failed previously with ndata=1 because it was a np scalar