Skip to content

Add a fallback to using all points for reports that are using old fits with bad filters.#1506

Merged
scarlehoff merged 3 commits into
masterfrom
allow_old_fit_with_bad_filters
Feb 5, 2022
Merged

Add a fallback to using all points for reports that are using old fits with bad filters.#1506
scarlehoff merged 3 commits into
masterfrom
allow_old_fit_with_bad_filters

Conversation

@scarlehoff
Copy link
Copy Markdown
Member

One example (I'm using generate_a_report.yaml as template) that would fail in current master (because the HERACOMBNCEM cuts do not exist). With this you get a million warnings but it works.
I think many warnings is better than a failure. Fixes #1505

fit: NNPDF31_nnlo_as_0118_DISonly

pdf:
  from_: "fit"

experiments:
  - experiment: TEST
    datasets:
      - {dataset: HERACOMBNCEM , frac: 0.5}

theoryid: 162

use_cuts: "fromfit"

template_text: |
  {@experiments::experiment plot_chi2dist@}

actions_:
  - report(main=True)

@scarlehoff scarlehoff added the run-fit-bot Starts fit bot from a PR. label Jan 28, 2022
@github-actions
Copy link
Copy Markdown

Greetings from your nice fit 🤖 !
I have good news for you, I just finished my tasks:

Check the report carefully, and please buy me a ☕ , or better, a GPU 😉!

Copy link
Copy Markdown
Contributor

@Zaharid Zaharid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss in some call.

@scarlehoff
Copy link
Copy Markdown
Member Author

This is now updated with what we talked about yesterday.
I guess we could even cache the cuts instead of loading them every time from the file but I guess it doesn't really matter.

@Zaharid Zaharid removed the run-fit-bot Starts fit bot from a PR. label Feb 4, 2022
@scarlehoff scarlehoff merged commit 733cc61 into master Feb 5, 2022
@scarlehoff scarlehoff deleted the allow_old_fit_with_bad_filters branch February 5, 2022 09:48
@Zaharid Zaharid added the enhancement New feature or request label May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a catch for old fits where setupfit didn't generate cuts correctly

2 participants