Add a fallback to using all points for reports that are using old fits with bad filters.#1506
Merged
Merged
Conversation
|
Greetings from your nice fit 🤖 !
Check the report carefully, and please buy me a ☕ , or better, a GPU 😉! |
Zaharid
requested changes
Feb 2, 2022
Contributor
Zaharid
left a comment
There was a problem hiding this comment.
Let's discuss in some call.
Member
Author
|
This is now updated with what we talked about yesterday. |
Zaharid
approved these changes
Feb 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One example (I'm using
generate_a_report.yamlas template) that would fail in current master (because the HERACOMBNCEM cuts do not exist). With this you get a million warnings but it works.I think many warnings is better than a failure. Fixes #1505