Change recommonmark for myst#1596
Closed
scarlehoff wants to merge 1 commit into
Closed
Conversation
Contributor
|
Since we are touching the md files anyway, how bad would it be to convert them to rst as per the original comment? Supporting the two things was quickly disliked by everyone, hence the note here https://docs.nnpdf.science/contributing/sphinx-documentation.html?highlight=rst |
Member
Author
If (if not, there's no hurry and it would be nice indeed) |
Member
Author
|
Closing in favour of #1597 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While it might not be the problem of #1537, this is something that we should've done some time ago given #1220 (comment)
I think that the documentation produced by this branch is equal to the documentation in master (actually, a bit better because I've fixed a few broken links I've found) but I've only checked by eye.