Add photon

[niclaurenti]

• Do a fit with Theory 133 (3.1)
• Compare with a fit with Theory 53 (3.1)
• Add tests (and fix tests) to this PR
• add fiatlux to conda recipe
• add eko to conda recipe
• restore top-level imports
• add documentation
• (optional) make fiatlux accept dict as input
• Run black and isort using pyproject.toml from master

[RoyStegeman]

Should this already be reviewed (after fixing the comput_photon path)?

[niclaurenti]

Should this already be reviewed (after fixing the comput_photon path)?

Hi @RoyStegeman, no it is not ready. i opened the pull request so that me @alecandido @scarlehoff and whoever is interested can discuss on its implementation.

[RoyStegeman]

That's what I assumed, thanks

[scarlehoff]

Have a look at #1644 and rebase this branch on top of that one (or even copy the changes you want on top of that one). In that one you have the xgrid before creating the model.

[RoyStegeman]

I left a few comments here and there. In general I would recommend to keep your code a bit cleaner, even if the intention is just to prototype instead of creating a final product. That helps us since it's easier to read and yourself in the end as well.

[RoyStegeman]

But yes on my part it's fine to run black and isort on all files, I think I've asked enough for one PR ;)

[scarlehoff]

Did you look at the tests @scarlehoff?

Since we agreed that the tests will be revisited in the future with a "theory 398" with a smallish photon I didn't double down on them but I stand by my previous review of those.

Let me link here two comments that should be dealt with:

• https://github.com/NNPDF/nnpdf/pull/1643/files#r1146321927
• https://github.com/NNPDF/nnpdf/pull/1643/files#r1155696692

But I think it would be easier (and less overwhelming for @niclaurenti, this is already gigantic as it is) to do that after merging the code.

it would be good to add docs

It would. Maybe a few lines here https://docs.nnpdf.science/n3fit/runcard_detailed.html detailing the fiatlux dictionary would be nice.

[RoyStegeman]

Maybe a few lines here https://docs.nnpdf.science/n3fit/runcard_detailed.html

For symmetry reasons with MHOU fits I think it makes more sense to put a section "how to do a qed fit" under "tutorials"

[RoyStegeman]

@niclaurenti I think you ran black and isort using the default settings instead of those in pyproject.toml https://github.com/NNPDF/nnpdf/blob/master/pyproject.toml.

Please revert the last commit and rerun with those settings

[github-actions]

Greetings from your nice fit 🤖 !
I have good news for you, I just finished my tasks:

• Fit Name: NNBOT-f62933ee7-2023-05-17
• Fit Report: https://vp.nnpdf.science/RMdetaOlQkmDZWVJKeHjdg==
• Fit Data: https://data.nnpdf.science/fits/NNBOT-f62933ee7-2023-05-17.tar.gz

Check the report carefully, and please buy me a ☕ , or better, a GPU 😉!

[scarlehoff]

It seems that you forgot to update the test in the max_q2 commit. Once that is done we can merge this.

(I've moved the point about theory 398 to this issue #1735. Since I'll have more time next week I'll see about creating the small ekos to test the lhapdf info files as well)

[andreab1997]

@niclaurenti please fix also this other evolven3fit_new problem

nnpdf/n3fit/src/evolven3fit_new/evolve.py

Line 71 in af6dc83

log.setFormatter(logging.Formatter(LOGGING_SETTINGS["formatter"]))

Here you just need to remove logging.Formatter(