fix default elements for ccbar_asymm basis#1649
Conversation
|
Please add a test somewhere. The way this is done at the moment is changing evolution as well. Not sure that is intended. |
|
ah right |
|
I think it s probably better to redefine the basis altogether? I mean without doing |
|
You could also just use |
Specifically `CCBAR_ASYMM = copy.deepcopy(evolution)`. Without deepcopy edits to CCBAR_ASYMM attributes overwrite attributes in evolution basis.
|
I think this would be good to be merged (and since we are discussing ccbar I'd feel better if we are all in the same page -or branch-) @Zaharid what kind of tests would you add? |
|
Yes this should be merged, don't want to keep the current bugged (buggish?) implementation in main. Also wondering about what tests you had in mind. There's not really a clean way to test it, unless we want to do so for all bases explicitly just to prevent us from doing something like this again. Perhaps instead we should just remove |
V15was missing from thedefualts_elemetsof theCCBAR_ASYMMand this was breakingvp-nextfitruncard