Python closure sampling#1651
Conversation
… create systype dir
…used for the generation of level1 noise: filterseed. rngalgo and seed are not needed anymore to run a closure test
…with cuts already applied
|
I think it should be like Then we may (or not) have a simple function like or else have the equivalent functionality in the export function or whatever. The idea is that one can use the lower level interface to write to things that are not quite files such as memory maps, compressed archives or indeed strings (using stringio as in the example). |
| level1_data = make_replica(level0_commondata_wc, filterseed, covmat, | ||
| sep_mult=False, genrep=True) | ||
|
|
||
| group_index = groups_index([data]) # already set cuts |
There was a problem hiding this comment.
Why not having group_index as a provider here instead?
There was a problem hiding this comment.
I think there is already one called experiments_index in results.py.
In the new commits I pass it to the filter_closure_data_by_experiment function which loops over the experiments so that the right indexes are passed to the _filter_closure_data function
|
|
||
|
|
||
|
|
||
| def make_level1_data(data,commondata_wc,level0_commondata_wc,filterseed): |
There was a problem hiding this comment.
I think we should have a vp provider that does commondata_wc provider, so that this function can be used as an action.
There was a problem hiding this comment.
I added a commondata_wc function in results.py. Also, in the new commits the make_level0_data has been renamed level0_commondata_wc
|
This now lives in #1660. |
Main modification: Level 1 data used for closure tests generated by validphys.pseudodata.make_replica instead of libnnpdf.experiments.MakeClosure.
Closure tests no longer depend on the prepare_nnpdf_rng function which uses the c++ rng (see #1623 ). As a consequence "seed" and "rngalgo" are no longer needed in a closure test runcard, the random initializer only depends on "filterseed"