Skip to content

Allow different matching scale for the photon #1751

Merged
niclaurenti merged 9 commits into
masterfrom
different-qin
Jun 13, 2023
Merged

Allow different matching scale for the photon #1751
niclaurenti merged 9 commits into
masterfrom
different-qin

Conversation

@niclaurenti
Copy link
Copy Markdown
Contributor

@niclaurenti niclaurenti commented Jun 5, 2023

Opening this PR to allow different matching scale for the photon. With matching scale here I mean the scale at which the photon is generated (that now is hardcoded to 100 GeV), and not the scale at which we change nf in the VFNS (I know, it is a bit confusing).
The matching scale will be read from the eko_photon.tar so it will not be neither in the runcard, nor in the theory card.
It means that there will be some copies of theory 523 that will change only for eko_photon.tar.

Honestly, I don't like very much the idea that in order to find out what the matching scale is for a given theory, one has to open eko_photon.tar and read eko_photon.mu20 so if you have better ideas please let me know

edit: in this PR i will also upgrade the photon branch to eko 0.13

@niclaurenti
Copy link
Copy Markdown
Contributor Author

Honestly, I don't like very much the idea that in order to find out what the matching scale is for a given theory, one has to open eko_photon.tar and read eko_photon.mu20 so if you have better ideas please let me know

Anyway, if no one has better suggestions, I would add these new theories to the theory.db and push them in the server.

Comment thread validphys2/src/validphys/photon/compute.py
@scarlehoff
Copy link
Copy Markdown
Member

Honestly, I don't like very much the idea that in order to find out what the matching scale is for a given theory, one has to open eko_photon.tar and read eko_photon.mu20 so if you have better ideas please let me know

From what I understand, a given theory will only have one matching scale. So if I have theory 523 I will have q_matching=100 GeV, right? So that information should be in the theory database.

@niclaurenti
Copy link
Copy Markdown
Contributor Author

@scarlehoff You mean that we should add an entry Q_in (or Q_match we can discuss about the name) in the theory card?

@scarlehoff
Copy link
Copy Markdown
Member

Yes. But for now it should be added to the description so that the information is there.

@niclaurenti niclaurenti marked this pull request as ready for review June 13, 2023 09:53
Comment thread n3fit/src/evolven3fit_new/eko_utils.py
Comment thread validphys2/src/validphys/photon/compute.py Outdated
@RoyStegeman
Copy link
Copy Markdown
Member

@scarlehoff You mean that we should add an entry Q_in (or Q_match we can discuss about the name) in the theory card?

Yes this seems like a good idea.

Yes. But for now it should be added to the description so that the information is there.

I believe this still needs to be done. I.e. adding under "Comments" the matching scale.

Copy link
Copy Markdown
Member

@scarlehoff scarlehoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to have theory 398 ready soonish in order to make sure these changes didn't break anything. Also because the tests should've told us that the photon was broken for the new versions of eko (but it didn't because there aren't of course)

RE this PR, from now on the input scale of the photon is read from eko and, since for one theory it will be fixed. But since we don't have that entry because it used to be just 100 GeV, the Q_in of the eko is written in the description. Is that correct?

Comment thread n3fit/src/evolven3fit_new/eko_utils.py
Comment thread n3fit/src/evolven3fit_new/eko_utils.py
@niclaurenti
Copy link
Copy Markdown
Contributor Author

It would be good to have theory 398 ready soonish in order to make sure these changes didn't break anything. Also because the tests should've told us that the photon was broken for the new versions of eko (but it didn't because there aren't of course)

Yes I'm working on it :)

RE this PR, from now on the input scale of the photon is read from eko and, since for one theory it will be fixed. But since we don't have that entry because it used to be just 100 GeV, the Q_in of the eko is written in the description. Is that correct?

Exactly, I have added three theories (524, 525, 526) that are identical to 523 but have a different Q_IN and it is spelled out in the description of the theory

@niclaurenti niclaurenti merged commit 6bfc220 into master Jun 13, 2023
@niclaurenti niclaurenti deleted the different-qin branch June 13, 2023 13:38
# Apply EKO to PDFs
q2 = eko.mu2grid[0]
with eko.operator(q2) as elem:
for _, elem in eko.items():
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a for loop assuming that there is a single element is not the best style ever...
If you only care about the first one, you could use next(iter(eko)) to get the index you need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants