Skip to content

Fix custom_group processing#1753

Merged
Zaharid merged 2 commits into
masterfrom
fixcustomgroup
Jun 8, 2023
Merged

Fix custom_group processing#1753
Zaharid merged 2 commits into
masterfrom
fixcustomgroup

Conversation

@Zaharid
Copy link
Copy Markdown
Contributor

@Zaharid Zaharid commented Jun 8, 2023

Because we use if instead of elif, the code would search for the custom_group key in the runcard.

@Zaharid Zaharid added the bug Something isn't working label Jun 8, 2023
Copy link
Copy Markdown
Member

@RoyStegeman RoyStegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this

Comment thread validphys2/src/validphys/config.py Outdated
Because we use if instead of elif, the code would search for the
custom_group key in the runcard.
Copy link
Copy Markdown
Member

@RoyStegeman RoyStegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

Before this fix the if processed_metadata_group=="custom_group" statement was rendered useless

@Zaharid Zaharid merged commit e0237b9 into master Jun 8, 2023
@Zaharid Zaharid deleted the fixcustomgroup branch June 8, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants