You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Implements an old TODO by @scarlehoff to write the FkRotation layer as a subclass of Rotation.
Unlike for FlavourToEvolution the rotation matrix is fixed, so I thought it made sense to define it right in the class.
Unrelated to this, the docstring isn't accurate, referring to 8 dimensions while actually there are 9. This may be a good occasion to fix it, but I'm not sure what to write as I don't know where the +1 is from, any suggestion?
I've verified that this gives the same output using the script below, and also checked that the new way is about 3-5 times faster.
Unlike for FlavourToEvolution the rotation matrix is fixed, so I thought it made sense to define it right in the class.
Yes, indeed. And in any case, it is better than the combination "by hand" that we had right now imho. Thanks!
Unrelated to this, the docstring isn't accurate, referring to 8 dimensions while actually there are 9. This may be a good occasion to fix it, but I'm not sure what to write as I don't know where the +1 is from, any suggestion?
The +1 is coming form the addition of V15 to the fit, in order to allow for the charm-anticharm asymmetry a few months ago. During that change it was anticipated that some "8s" would need to be changed by hand, I'm happy that it's only docs for now :P #1629 (comment) so please update the docstr!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements an old TODO by @scarlehoff to write the
FkRotationlayer as a subclass ofRotation.Unlike for
FlavourToEvolutionthe rotation matrix is fixed, so I thought it made sense to define it right in the class.Unrelated to this, the docstring isn't accurate, referring to 8 dimensions while actually there are 9. This may be a good occasion to fix it, but I'm not sure what to write as I don't know where the +1 is from, any suggestion?
I've verified that this gives the same output using the script below, and also checked that the new way is about 3-5 times faster.