Skip to content

Restart hyperopt#1812

Closed
Cmurilochem wants to merge 0 commit into
masterfrom
restart_hyperopt
Closed

Restart hyperopt#1812
Cmurilochem wants to merge 0 commit into
masterfrom
restart_hyperopt

Conversation

@Cmurilochem
Copy link
Copy Markdown
Collaborator

This PR addresses the issue of restarting an hyperoptimization with the Hyperopt library as discussed in #1800.

@Radonirinaunimi
Copy link
Copy Markdown
Member

Radonirinaunimi commented Oct 16, 2023

The changes here seem to me more complicated than it should, but we can discuss further this afternoon. And btw, as it stands, I don't think this PR should point to master.

@Radonirinaunimi Radonirinaunimi changed the base branch from master to hyperopt_loss October 16, 2023 11:51
@RoyStegeman
Copy link
Copy Markdown
Member

Hi @Cmurilochem the diffs are a bit difficult to understand, it seems that you have a lot of commits that are already included in master while you're trying to work/merge on top of a branch that does not have these commits?

Perhaps this should be pointed to master and @Radonirinaunimi change should be undone or mabye the hyperopt_loss branch should be rebased (though if this was branched off from master you may need to rebase this on top of hyperopt_loss if that's what you want)? Either way, before continuing your progress you may want to make sure the history makes sense and you will be able to safely merge by the time that's needed.

@Radonirinaunimi
Copy link
Copy Markdown
Member

Hi @Cmurilochem the diffs are a bit difficult to understand, it seems that you have a lot of commits that are already included in master while you're trying to work/merge on top of a branch that does not have these commits?

Perhaps this should be pointed to master and @Radonirinaunimi change should be undone or mabye the hyperopt_loss branch should be rebased (though if this was branched off from master you may need to rebase this on top of hyperopt_loss if that's what you want)? Either way, before continuing your progress you may want to make sure the history makes sense and you will be able to safely merge by the time that's needed.

Indeed! Now it is very complicated to understand which changes genuinely regards the continuation of hyperopt. As I mentioned a while ago, you basically have two options:

  • Point the following PR to master. This would be feasible because even the current master could benefit from this feature. But for this you'll have to undo the changes that are coming from the hyperopt_loss and other branches.
  • Point this PR to hyperopt_loss branch but then never merge/rebase stuff from the various merges/fixes.

At this point I'd say the first option is the most ideal, and once merged could be propagated throughout the different branches. There should be only single (main) branch from which all the various changes are collected (if needed) but this should not bet that branch.

@Radonirinaunimi
Copy link
Copy Markdown
Member

So, that is, the diffs here should only show the changes regarding the continuation of hyperopt and the documentation describing how it is used.

@Radonirinaunimi Radonirinaunimi changed the base branch from hyperopt_loss to master October 24, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow for hyperoptimization restart from tries.json Hyperopt checkpointing/restarting

3 participants