bugfix with stopping#1820
Merged
Merged
Conversation
…o public as they are used during hyperoptimization
RoyStegeman
approved these changes
Oct 18, 2023
Member
I can't find this branch, did you already delete it yourself? |
Collaborator
Author
|
@RoyStegeman I didn't, I don't think I have permissions for it, but I don't see it either so I guess someone else did. |
Member
|
I did! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for a bug introduced in #1792 for hyperoptimization, I prepended an underscore to some attributes I thought were only used in the class, but they are actually used in hyperoptimization.
Please also delete the branch fix-stopping-patience-bug, which I accidentally based on a branch other than master.