dis+jets implementation#1825
Conversation
New jet data
scarlehoff
left a comment
There was a problem hiding this comment.
Haven't tested them yet, only had a look through the metadata, some general comments.
|
@enocera one question about the generic DIS cuts that we have in the code (I have a weak recollection of having talk about this or something similar), should they also apply by default to these datasets? If yes, maybe it is good to add the (the q2 cut should work by itself) |
|
The DIS+jet data sets are NOT subject to the generic cuts for DIS we have in the code (certainly not to the x cut; for Q, I'd say that all the data points are above the nominal cut, see Table 2.2 in the NNPDF4.0 paper. So, even if the Q2 cut is there and even if it works, it should have no effect). However, we may want to have a cut in pT, which, I hope, can be implemented in filters.yaml. I need to check the HERA paper to retrieve the optimal value for the cut in pT. |
|
The kinematic cut to be implemented is (pT^2+Q^2)>100 GeV2 (that is, one should retain points with pT^2+Q^2 larger than 100 GeV2). |
|
Using the aforementioned cut, you should see the reduction of data points summarised in Table 1 of https://arxiv.org/pdf/2112.01120.pdf. |
|
@enocera @scarlehoff I have changed the H1 351pb-1 datasets to now use the tables given by kt (instead of anti-kt). I think with this, the numbers should match with the old implementation. |
The |
0c9b2bd to
902e9bb
Compare
|
This PR is now fully ready with all the suggestions from above implemented. |
902e9bb to
cf55efb
Compare
|
Thanks for this. I guess you already tested this with the reader and checked that it worked after your changes? |
@scarlehoff Thanks for reminding me of this, I was counting on from pdf4lhc times. I just tried to do a DTC and got this error: However, to avoid delaying this PR merging, I remove the 'hera' part from my local copy metadatfiles in process types to be able to produce DTC, and it works well for me, here it is for reference: https://vp.nnpdf.science/92VrFzd4RI-HkEUf4F5zIg== so to sum up: yes, it's tested and working well, however we need the above mentioned fix in #1678 |
|
Completely forgot about them! This is a great candidate to start adding only the entries that are required (such as the q-x mapping) @enocera @felixhekhorn how would you compute |
if possible I'd like to change the behaviour on the kinPlot to a more physical one (in my opinion) ... @enocera, I guess there are reasons on why it was chosen in the old way it was chosen, so maybe I'm missing something ... however, speaking as a theorist I would argue the following way:
|
|
I'm not sure the x coverage is 100% correct, maybe some of the approximations were too approximated (or I made a mistake coding the formula). https://vp.nnpdf.science/vxS8mWGySsu-cehRFnhSOA== Both the process label and the formula can be modified in this file: |
|
The formula looks correct (from what ERN told us that day). Why do you say the x plot seems incorrect? |
|
I've merged and rebased this branch onto master: 625372d |
Almost 10^-7 looks too small for me. Maybe there was a square missing. |
can you check against the grids? |

No description provided.