Skip to content

add skip_magic_trailing_comma to black config#1828

Merged
RoyStegeman merged 1 commit into
masterfrom
update_pyproject_trailingcomma
Oct 30, 2023
Merged

add skip_magic_trailing_comma to black config#1828
RoyStegeman merged 1 commit into
masterfrom
update_pyproject_trailingcomma

Conversation

@RoyStegeman
Copy link
Copy Markdown
Member

If a function input has a trailing comma black will not put the inputs on a single line, even if the line-length would be less than the specified length. I believe this is done to minimize diff, but I think it's undesirable: #1824 (comment)

@RoyStegeman RoyStegeman mentioned this pull request Oct 30, 2023
@RoyStegeman RoyStegeman added the devtools Build, automation and workflow label Oct 30, 2023
Copy link
Copy Markdown
Member

@scarlehoff scarlehoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

@RoyStegeman RoyStegeman merged commit 997df63 into master Oct 30, 2023
@RoyStegeman RoyStegeman deleted the update_pyproject_trailingcomma branch October 30, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devtools Build, automation and workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants