Skip to content

TTB integrated x-sec datasets#1834

Closed
t7phy wants to merge 17 commits into
new_commondata_collectedfrom
ncd_top_1
Closed

TTB integrated x-sec datasets#1834
t7phy wants to merge 17 commits into
new_commondata_collectedfrom
ncd_top_1

Conversation

@t7phy
Copy link
Copy Markdown
Collaborator

@t7phy t7phy commented Nov 4, 2023

No description provided.

@t7phy t7phy changed the title TTB inc x-sec datasets TTB integrated x-sec datasets Nov 4, 2023
@scarlehoff scarlehoff force-pushed the new_commondata_collected branch from b2e9195 to e64d092 Compare November 17, 2023 16:20
@t7phy t7phy marked this pull request as ready for review December 7, 2023 15:53
@t7phy t7phy requested a review from scarlehoff December 7, 2023 15:53
Copy link
Copy Markdown
Member

@scarlehoff scarlehoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I've done a first test, I find some differences in the data. When this difference is expected please write something about it in the PR (in order to know whether it is a bug or a feature).

For Atlas only the 7 TeV one agrees for everything. I find some differences in the t0 chi2 which is pointing to a difference in the treatment or MULT and ADD?

 > Testing old: ATLASTTBARTOT7TEV vs new: ATLAS_TTBAR_7TEV_TOT_X-SEC
The t0 chi2 is different: 2194.2430166777112 vs 1102.1581162540726

 > Testing old: ATLASTTBARTOT8TEV vs new: ATLAS_TTBAR_8TEV_TOT_X-SEC
Data differences under 1e-2, continuing comparison...
	 242.4  242.9
# Differences in the computation of chi2 391.76 vs 548.71
    The covmats are different
    even the diagonal
    
 > Testing old: ATLASTTBARTOT13TEV vs new: ATLAS_TTBAR_13TEV_TOT_X-SEC
Relative differences above 1e-2                 
	 818.0   830 

For CMS instead I find perfect agreement for everything but the 13 TeV one, where there's a big difference in the results:

792.0   746 

So for now I've done the following report only for CMS: https://vp.nnpdf.science/WEzTkruoTt6kZNpn8igKdA==

Comment thread buildmaster/CMS_TTBAR_8TEV_TOT/metadata.yaml Outdated
@t7phy
Copy link
Copy Markdown
Collaborator Author

t7phy commented Dec 8, 2023

Thanks for this! I've done a first test, I find some differences in the data. When this difference is expected please write something about it in the PR (in order to know whether it is a bug or a feature).

For Atlas only the 7 TeV one agrees for everything. I find some differences in the t0 chi2 which is pointing to a difference in the treatment or MULT and ADD?

 > Testing old: ATLASTTBARTOT7TEV vs new: ATLAS_TTBAR_7TEV_TOT_X-SEC
The t0 chi2 is different: 2194.2430166777112 vs 1102.1581162540726

 > Testing old: ATLASTTBARTOT8TEV vs new: ATLAS_TTBAR_8TEV_TOT_X-SEC
Data differences under 1e-2, continuing comparison...
	 242.4  242.9
# Differences in the computation of chi2 391.76 vs 548.71
    The covmats are different
    even the diagonal
    
 > Testing old: ATLASTTBARTOT13TEV vs new: ATLAS_TTBAR_13TEV_TOT_X-SEC
Relative differences above 1e-2                 
	 818.0   830 

For CMS instead I find perfect agreement for everything but the 13 TeV one, where there's a big difference in the results:

792.0   746 

So for now I've done the following report only for CMS: https://vp.nnpdf.science/WEzTkruoTt6kZNpn8igKdA==

Actually I am pretty confident about the data and uncer. here because there is no data implementation here, everything is taken just from arxiv papers directly and I jut rechecked the values, it does appear to be consistent. Why does the old implementation differ? That I am not sure tbh. A possibility is that values have changed on arXiv due to improved lumi...??

@scarlehoff
Copy link
Copy Markdown
Member

There's a comment about a fix in the old implementation https://github.com/NNPDF/nnpdf/blob/master/nnpdfcpp/data/commondata/DATA_CMSTTBARTOT13TEV.dat

Maybe @enocera remembers

@scarlehoff scarlehoff mentioned this pull request Dec 8, 2023
@felixhekhorn
Copy link
Copy Markdown
Contributor

A (slightly) unrelated comment (but since I saw this in my newsfeed I decided to post it nevertheless - feel free to discard it as off-topic): I assume this is about fully inclusive ttbar xs (and the jets are in this PR by mistake), right?

I'm currently working on MaunaKea a.k.a. "Hawaiian top++" patched on top of top++ by Czakon and Mitov for my work here in Jyväskylä - do we want to use this eventually on the theory side? The theory is currently provided by mg5 which means it is limited to NLO, but I could go full NNLO. The impact on the fit will be 0 since we talking about the grand total of 7 datapoints (associated to this PR).

@scarlehoff
Copy link
Copy Markdown
Member

Yes, I think that will be great! I mean, just for consistency sake it is worth it.

@t7phy
Copy link
Copy Markdown
Collaborator Author

t7phy commented Dec 8, 2023

A (slightly) unrelated comment (but since I saw this in my newsfeed I decided to post it nevertheless - feel free to discard it as off-topic): I assume this is about fully inclusive ttbar xs (and the jets are in this PR by mistake), right?

The jets appear in the commits because the branch that is collecting the datasets already has the jets merged as they were considered finalized and done

@scarlehoff
Copy link
Copy Markdown
Member

To be corrected in the list of legacy dataset names:

ATLAS_TTBAR_13TEV_TOT_X-SEC should be compared against ATLAS_TTBARTOT_13TEV_FULLLUMI

When doing this change, everything is ok.

The difference for the CMSTTBARTOT13TEV vs CMS_TTBAR_13TEV_TOT_X-SEC remains though and should be understood. The difference is 792.0 746
We need to understand whether maybe CMS_TTBAR_13TEV_TOT_X-SEC and CMSTTBARTOT13TEV actually correspond to different datasets.

@t7phy
Copy link
Copy Markdown
Collaborator Author

t7phy commented Dec 18, 2023

@scarlehoff

The difference for the CMSTTBARTOT13TEV vs CMS_TTBAR_13TEV_TOT_X-SEC remains though and should be understood. The difference is 792.0 746 We need to understand whether maybe CMS_TTBAR_13TEV_TOT_X-SEC and CMSTTBARTOT13TEV actually correspond to different datasets.

So nnpdf uses https://arxiv.org/abs/1510.05302, which is exactly what I have used too:
the values on arxiv are:
v1: 769
v2 and v3: 746
I am unable to find 792 anywhere. Is 'CMSTTBARTOT13TEV' used in the 4.0 runcard?

@scarlehoff
Copy link
Copy Markdown
Member

scarlehoff added a commit that referenced this pull request Feb 1, 2024
@scarlehoff scarlehoff force-pushed the new_commondata_collected branch from e64d092 to 929b692 Compare February 1, 2024 14:26
@scarlehoff scarlehoff closed this Feb 1, 2024
scarlehoff added a commit that referenced this pull request Feb 6, 2024
scarlehoff added a commit that referenced this pull request Feb 7, 2024
scarlehoff added a commit that referenced this pull request Feb 7, 2024
scarlehoff added a commit that referenced this pull request Feb 12, 2024
@scarlehoff scarlehoff deleted the ncd_top_1 branch February 15, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants