Enable conda package for 3.11#1890
Merged
Merged
Conversation
scarlehoff
force-pushed
the
enable_python311_condaenv
branch
from
b5aba20 to
cb016e5
Compare
RoyStegeman
approved these changes
Dec 12, 2023
Member
RoyStegeman
left a comment
RoyStegeman
left a comment
There was a problem hiding this comment.
This is fine to merge, thanks!
RoyStegeman
reviewed
Dec 12, 2023
|
Greetings from your nice fit 🤖 !
Check the report carefully, and please buy me a ☕ , or better, a GPU 😉! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1871 I've been able to test with 3.11 (although I had to change some test thresholds).
This PR tries to prepare the package for python 3.11. If this works well (even lowering the threshold) I think it would be a good idea to merge before the final tag so that we have 3.9 to 3.11 with 4.0.7
Note that for 4.0.8 if everything goes according to plan the conda package for nnpdf will not depend on any version of python since nnpdf will be python-only.
Edit:
Turns out the problem with conda was a pinned libarchive many moons ago (which we pinned because of a problem with conda!)
During the testing I've also removed eigen since the tensorflow package in anaconda has not been updated in a while. I've tested in my computer (with linux and python 3.9) and there is no memory leak anymore it seems?
However, I think I'm going to have a slightly different conda-recipe for 3.9/3.10 and 3.11 to avoid changing things too much for the next tag.