Fix dataset/prediction ordering problem in theory covmat creation#1899
Merged
Conversation
scarlehoff
reviewed
Dec 19, 2023
andreab1997
reviewed
Dec 19, 2023
Contributor
andreab1997
left a comment
andreab1997
left a comment
There was a problem hiding this comment.
For the moment I only had a quick look, I will have a more careful look later
scarlehoff
reviewed
Dec 19, 2023
RoyStegeman
changed the title
scarlehoff
approved these changes
Dec 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we should probably use
reindexin most (all?) places where multiple dataframes with the same labels in the index are being loaded.