Implementation of hyperopt model selection#1976
Closed
Cmurilochem wants to merge 8 commits into
Closed
Conversation
fe55608 to
8679dca
Compare
d7a3873 to
e5294e8
Compare
e5294e8 to
14efc0c
Compare
14efc0c to
21c5a06
Compare
21c5a06 to
695c722
Compare
2ea055a to
aa61cb7
Compare
…cas of the best fit
b44c2ee to
535ea80
Compare
Member
|
Can we review plus merge this now @Radonirinaunimi or do we want to wait for ref. replies? |
Member
|
Now that the paper is accepted, should we merge this as is? |
Member
|
@Radonirinaunimi what do we do with this PR? |
Member
|
This is now overly deprecated so let's close it (and in any case it will be removed in favor of the new sampling). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to implement #1962 into
validphysvp-hyperoptplot.py.Updates
The model selection following to the
min_chi2_max_phialgorithm (refactored frombest_chi2_worst_phi2in #1962) could be done in two ways:1. via a basic script that imports validphys
hyperopt_dataframeAn example is shown below:
where
best_setupcorresponds to the model which shows the lowest 1/phi among those with the lowest chi2, whilebest_modelsis a pandasDataFramecontaining allmax_phi_n_models.2. via vp-hyperoptplot
by running:
which would launch an html file in your browser with some statistics and plots (I thinks this could be shared within the NNPDF server later on)
TODO: add a table in the html file containing the detailed specs of
best_models.