Skip to content

hyperopt runcard#1986

Merged
scarlehoff merged 4 commits into
masterfrom
new-hyperopt-runcard
Mar 8, 2024
Merged

hyperopt runcard#1986
scarlehoff merged 4 commits into
masterfrom
new-hyperopt-runcard

Conversation

@APJansen
Copy link
Copy Markdown
Collaborator

@APJansen APJansen commented Mar 6, 2024

I thought it would be useful to discuss this in a PR. I've added the runcard that we used for the hyperopt runs so far (please confirm I got the right one @Cmurilochem).
I just picked a name but this can of course change, as long as it refers to the paper in some way.

I think what needs to be done is:

  • Add back the full hyperparameter space of the original hyperopt runcard
  • Change the theory to 700, right?
  • Update any legacy names

And of course before we do any serious runs, have everyone do a careful check that this is what we want to run.

@Cmurilochem
Copy link
Copy Markdown
Collaborator

I thought it would be useful to discuss this in a PR. I've added the runcard that we used for the hyperopt runs so far (please confirm I got the right one @Cmurilochem). I just picked a name but this can of course change, as long as it refers to the paper in some way.

I think what needs to be done is:

  • Add back the full hyperparameter space of the original hyperopt runcard
  • Change the theory to 700, right?
  • Update any legacy names

And of course before we do any serious runs, have everyone do a careful check that this is what we want to run.

Thanks @APJansen. The one I am using is indeed defined in 5743053

@scarlehoff
Copy link
Copy Markdown
Member

Let me update the runcard (and I'll deal with #1984 in the process)
I will also change the name since god only knows when 4.1 will happen.

@APJansen
Copy link
Copy Markdown
Collaborator Author

APJansen commented Mar 6, 2024

Haha yes I figured, didn't know what other else to name it though. Thanks!

@Cmurilochem
Copy link
Copy Markdown
Collaborator

Let me update the runcard (and I'll deal with #1984 in the process) I will also change the name since god only knows when 4.1 will happen.

Thanks @scarlehoff!

@scarlehoff
Copy link
Copy Markdown
Member

Done. You can see I'm not that good with names.

@scarlehoff scarlehoff mentioned this pull request Mar 6, 2024
@APJansen
Copy link
Copy Markdown
Collaborator Author

APJansen commented Mar 6, 2024

Haha great, it runs! Thanks :)

@Cmurilochem
Copy link
Copy Markdown
Collaborator

Haha great, it runs! Thanks :)

It also resolved for me

def get_experimental_data(dataset_name="NMC_NC_NOTFIXED_P_EM-SIGMARED", theoryid=399):
    """Get experimental data set using validphys.

    Returns a list defined by the data set as
    `validphys.core.DataGroupSpec`.
    """
    loader = Loader()
    ds = loader.check_dataset(dataset_name, theoryid=theoryid, cuts="internal", variant="legacy")
    return loader.check_experiment("My DataGroupSpec", [ds])

But I had to add variant="legacy" as done in the runcard. Thanks you!

@APJansen
Copy link
Copy Markdown
Collaborator Author

APJansen commented Mar 6, 2024

@scarlehoff I do still get warnings about Apfelcomb being used, and to update the commondata file. Is that important, and how to update it?

[WARNING]: Apfelcomb key is being used to read [('CMS_TTB_8TEV_2D_TTM_TRAP',), ('CMS_TTB_8TEV_2D_TTM_TRAP_TOT',)], please update the commondata file
[WARNING]: Apfelcomb key is being used to read [('ATLAS_TTB_8TEV_LJ_TRAP',), ('ATLAS_TTB_8TEV_LJ_TRAP_TOT',)], please update the commondata file
[WARNING]: Apfelcomb key is being used to read [('ATLAS_TTB_8TEV_LJ_TTRAP',), ('ATLAS_TTB_8TEV_LJ_TTRAP_TOT',)], please update the commondata file
[WARNING]: Apfelcomb key is being used to read [('ATLAS_TTB_8TEV_2L_TTRAP',), ('CMSTTBARTOT8TEV-TOPDIFF8TEVTOT',)], please update the commondata file
[WARNING]: Apfelcomb key is being used to read [('CMSTOPDIFF8TEVTTRAPNORM-TOPDIFF8TEVTTRAP',), ('CMSTOPDIFF8TEVTTRAPNORM-TOPDIFF8TEVTOT',)], please update the commondata file
[WARNING]: Apfelcomb key is being used to read [('ATLASZPT8TEVMDIST-ATLASZPT8TEV-MLLBIN1_ptZ', 'ATLASZPT8TEVMDIST-ATLASZPT8TEV-MLLBIN2_ptZ', 'ATLASZPT8TEVMDIST-ATLASZPT8TEV-MLLBIN3_ptZ', 'ATLASZPT8TEVMDIST-ATLASZPT8TEV-MLLBIN4_ptZ', 'ATLASZPT8TEVMDIST-ATLASZPT8TEV-MLLBIN6_ptZ')], please update the commondata file
[WARNING]: Apfelcomb key is being used to read [('ATLAS_DY_2D_8TEV_LOWMASS-ATLAS_DY_2D_8TEV-BIN1_rapidity', 'ATLAS_DY_2D_8TEV_LOWMASS-ATLAS_DY_2D_8TEV-BIN2_rapidity', 'ATLAS_DY_2D_8TEV_LOWMASS-ATLAS_DY_2D_8TEV-BIN3_rapidity', 'ATLAS_DY_2D_8TEV_LOWMASS-ATLAS_DY_2D_8TEV-BIN4_rapidity', 'ATLAS_DY_2D_8TEV_LOWMASS-ATLAS_DY_2D_8TEV-BIN5_rapidity', 'ATLAS_DY_2D_8TEV_LOWMASS-ATLAS_DY_2D_8TEV-BIN6_rapidity', 'ATLAS_DY_2D_8TEV_LOWMASS-ATLAS_DY_2D_8TEV-BIN7_rapidity')], please update the commondata file
[WARNING]: Apfelcomb key is being used to read [('D0ZRAP-D0_ZRAP_MCgrid_500M',), ('D0ZRAP-D0_ZNORM_MCgrid_500M',)], please update the commondata file
[WARNING]: Apfelcomb key is being used to read [('ATLAS_SINGLETOP_TCH_DIFF_7TEV_TBAR_RAP_NORM-aMCfast_obs_0', 'ATLAS_SINGLETOP_TCH_DIFF_7TEV_TBAR_RAP_NORM-aMCfast_obs_1', 'ATLAS_SINGLETOP_TCH_DIFF_7TEV_TBAR_RAP_NORM-aMCfast_obs_2'), ('ATLAS_SINGLETOP_TCH_DIFF_7TEV_TBAR_RAP_NORM-ATLAS_SINGLETOP_TCH_R_7TEV_TB',)], please update the commondata file
[WARNING]: Apfelcomb key is being used to read [('ATLAS_SINGLETOP_TCH_DIFF_7TEV_T_RAP_NORM-aMCfast_obs_0', 'ATLAS_SINGLETOP_TCH_DIFF_7TEV_T_RAP_NORM-aMCfast_obs_1', 'ATLAS_SINGLETOP_TCH_DIFF_7TEV_T_RAP_NORM-aMCfast_obs_2'), ('ATLAS_SINGLETOP_TCH_DIFF_7TEV_T_RAP_NORM-ATLAS_SINGLETOP_TCH_R_7TEV_T',)], please update the commondata file
[WARNING]: Apfelcomb key is being used to read [('ATLAS_SINGLETOP_TCH_DIFF_8TEV_TBAR_RAP_NORM-aMCfast_obs_0', 'ATLAS_SINGLETOP_TCH_DIFF_8TEV_TBAR_RAP_NORM-aMCfast_obs_1', 'ATLAS_SINGLETOP_TCH_DIFF_8TEV_TBAR_RAP_NORM-aMCfast_obs_2'), ('ATLAS_SINGLETOP_TCH_DIFF_8TEV_TBAR_RAP_NORM-ATLAS_SINGLETOP_TCH_R_8TEV_TB',)], please update the commondata file
[WARNING]: Apfelcomb key is being used to read [('ATLAS_SINGLETOP_TCH_DIFF_8TEV_T_RAP_NORM-aMCfast_obs_0', 'ATLAS_SINGLETOP_TCH_DIFF_8TEV_T_RAP_NORM-aMCfast_obs_1', 'ATLAS_SINGLETOP_TCH_DIFF_8TEV_T_RAP_NORM-aMCfast_obs_2'), ('ATLAS_SINGLETOP_TCH_DIFF_8TEV_T_RAP_NORM-ATLAS_SINGLETOP_TCH_R_8TEV_T',)], please update the commondata file

@scarlehoff
Copy link
Copy Markdown
Member

That has nothing to do with the runcard, it is the data itself that need to be updated so nothing to be worried about.

@APJansen
Copy link
Copy Markdown
Collaborator Author

APJansen commented Mar 6, 2024

As in we ignore it completely because the data isn't available yet, or do we need to update our local data before running?

@scarlehoff
Copy link
Copy Markdown
Member

scarlehoff commented Mar 6, 2024

Nono, everything is up to date (just using some old syntax that someone needs to update)
it looks more scary than it is so that people implementing new data don't use these features.

@APJansen APJansen marked this pull request as ready for review March 8, 2024 07:53
@APJansen
Copy link
Copy Markdown
Collaborator Author

APJansen commented Mar 8, 2024

I think everyone agrees on this runcard right? Can you force merge this @scarlehoff ? Don't think this needs the CI to pass ;P

@scarlehoff scarlehoff merged commit d33e0b2 into master Mar 8, 2024
@scarlehoff scarlehoff deleted the new-hyperopt-runcard branch March 8, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants