Skip to content

Enable python 3.12#1989

Merged
scarlehoff merged 9 commits into
masterfrom
enable_312_conda
Mar 11, 2024
Merged

Enable python 3.12#1989
scarlehoff merged 9 commits into
masterfrom
enable_312_conda

Conversation

@scarlehoff
Copy link
Copy Markdown
Member

@scarlehoff scarlehoff commented Mar 8, 2024

Now reportengine and pineappl are available for python 3.12
Let's see whether there's something else to be changed.

Closes #1970

edit: not sure why boa<=0.14 is a problem when python <3.12 gets 0.16, but once the fit bot tests that everything run I'll check that

@scarlehoff scarlehoff added run-fit-bot Starts fit bot from a PR. and removed run-fit-bot Starts fit bot from a PR. labels Mar 8, 2024
@RoyStegeman
Copy link
Copy Markdown
Member

RoyStegeman commented Mar 8, 2024

I guess you read it as well in the boa docs: https://github.com/mamba-org/boa?tab=readme-ov-file
but it seems that now rattler is the recommended way to build a package: https://github.com/prefix-dev/rattler-build/tree/main

rattler-build complained at my first attempt though

@scarlehoff
Copy link
Copy Markdown
Member Author

No I didn't, I hadn't look into this yet. I'll use conda-build then since I guess it is the only one guaranteed to stay...

@RoyStegeman
Copy link
Copy Markdown
Member

Indeed, if that doesn't increase the time beyond what is reasonable that's probably the way to go

@scarlehoff
Copy link
Copy Markdown
Member Author

I think the error (might) be coming from reportengine.

@scarlehoff
Copy link
Copy Markdown
Member Author

@comane chaged the generator to a list here https://github.com/NNPDF/reportengine/blob/93b94ade66e1139aafaf45ab3f57ecbfbd21dbed/src/reportengine/figure.py#L143 for parallelization reasons.
I've changed the tests but not sure whether it will have an effect somewhere else.

@RoyStegeman
Copy link
Copy Markdown
Member

RoyStegeman commented Mar 8, 2024

I think that would affect all figuregen calls, so in a lot of places in vp. I guess we just test a subset.

@scarlehoff scarlehoff added the run-fit-bot Starts fit bot from a PR. label Mar 8, 2024
@scarlehoff
Copy link
Copy Markdown
Member Author

I guess we just test a subset.

I think if the fitbot passes we can consider all the relevant places where figuregen is used are ok...
at good time to deal with this I guess #1449

@RoyStegeman
Copy link
Copy Markdown
Member

if the fitbot passes we can consider all the relevant places where figuregen is used are ok

That's a big "if", but I agree.

good time to deal with this I guess #1449

Yes indeed, I suppose it's the vp analogue of the n3fit regression tests

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 8, 2024

Greetings from your nice fit 🤖 !
I have good news for you, I just finished my tasks:

Check the report carefully, and please buy me a ☕ , or better, a GPU 😉!

@scarlehoff
Copy link
Copy Markdown
Member Author

tbh, for this we don't even need them to work as regression, just make sure that the runcards actually run

@scarlehoff
Copy link
Copy Markdown
Member Author

Sadly for reportengine we still need to install from git. Let's just point to the latest master for now there (since that should match what's in conda)

@scarlehoff scarlehoff removed the run-fit-bot Starts fit bot from a PR. label Mar 9, 2024
Comment thread pyproject.toml
scarlehoff and others added 4 commits March 11, 2024 14:27
The spiderplot needs a PolarAxes instead of the regular Axes that it
received through @ax_or_gca. Also `set_ticks` should have been
`set_xticks`.
@scarlehoff scarlehoff merged commit ee78828 into master Mar 11, 2024
@scarlehoff scarlehoff deleted the enable_312_conda branch March 11, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changes needed to enable Python 3.12

2 participants