Enable python 3.12#1989
Conversation
|
I guess you read it as well in the boa docs: https://github.com/mamba-org/boa?tab=readme-ov-file
|
|
No I didn't, I hadn't look into this yet. I'll use conda-build then since I guess it is the only one guaranteed to stay... |
|
Indeed, if that doesn't increase the time beyond what is reasonable that's probably the way to go |
|
I think the error (might) be coming from reportengine. |
|
@comane chaged the generator to a list here https://github.com/NNPDF/reportengine/blob/93b94ade66e1139aafaf45ab3f57ecbfbd21dbed/src/reportengine/figure.py#L143 for parallelization reasons. |
|
I think that would affect all |
I think if the fitbot passes we can consider all the relevant places where figuregen is used are ok... |
That's a big "if", but I agree.
Yes indeed, I suppose it's the vp analogue of the n3fit regression tests |
|
Greetings from your nice fit 🤖 !
Check the report carefully, and please buy me a ☕ , or better, a GPU 😉! |
|
tbh, for this we don't even need them to work as regression, just make sure that the runcards actually run |
|
Sadly for reportengine we still need to install from git. Let's just point to the latest master for now there (since that should match what's in conda) |
0ba6982 to
6a4200d
Compare
6a4200d to
7702d2c
Compare
The spiderplot needs a PolarAxes instead of the regular Axes that it received through @ax_or_gca. Also `set_ticks` should have been `set_xticks`.
Now reportengine and pineappl are available for python 3.12
Let's see whether there's something else to be changed.
Closes #1970
edit: not sure why
boa<=0.14is a problem when python <3.12 gets 0.16, but once the fit bot tests that everything run I'll check that