Skip to content

NNPDF data package#2009

Merged
scarlehoff merged 9 commits into
masterfrom
nnpdf_data_package
Mar 18, 2024
Merged

NNPDF data package#2009
scarlehoff merged 9 commits into
masterfrom
nnpdf_data_package

Conversation

@comane
Copy link
Copy Markdown
Member

@comane comane commented Mar 15, 2024

This PR addresses #1942

The validphys/datafiles are moved into a directory nnpdf_data with it's own pyproject.toml.

@comane
Copy link
Copy Markdown
Member Author

comane commented Mar 15, 2024

#1965

@comane comane changed the title Nnpdf data package NNPDF data package Mar 15, 2024
@comane comane mentioned this pull request Mar 15, 2024
@comane comane requested a review from scarlehoff March 15, 2024 20:39
@comane comane force-pushed the nnpdf_data_package branch from 818b548 to 6a25a74 Compare March 15, 2024 21:38
@comane
Copy link
Copy Markdown
Member Author

comane commented Mar 15, 2024

Why are the pyproject.toml files not displayed in the "Files Changed"?

@scarlehoff
Copy link
Copy Markdown
Member

I think there's too many files changed (due to moving the files from one folder to the other).

It would be good to add here the excludes that are in the main nnpdf pyproject

[tool.poetry.dependencies]

so that rawdata and filters are not installed.

@scarlehoff scarlehoff added the run-fit-bot Starts fit bot from a PR. label Mar 17, 2024
@scarlehoff scarlehoff added run-fit-bot Starts fit bot from a PR. and removed run-fit-bot Starts fit bot from a PR. labels Mar 17, 2024
@github-actions
Copy link
Copy Markdown

Greetings from your nice fit 🤖 !
I have good news for you, I just finished my tasks:

Check the report carefully, and please buy me a ☕ , or better, a GPU 😉!

Copy link
Copy Markdown
Member

@scarlehoff scarlehoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@scarlehoff scarlehoff removed the run-fit-bot Starts fit bot from a PR. label Mar 18, 2024
@scarlehoff scarlehoff merged commit 2efbb73 into master Mar 18, 2024
@scarlehoff scarlehoff deleted the nnpdf_data_package branch March 18, 2024 14:01
@scarlehoff scarlehoff mentioned this pull request May 20, 2024
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants