Separate the theorydb utilities into the data package#2018
Merged
Conversation
Contributor
|
Do you want to do a further rename here |
Member
Author
|
No, at the moment externally these are just the utilities. |
giacomomagni
approved these changes
Mar 25, 2024
RoyStegeman
reviewed
Mar 25, 2024
RoyStegeman
approved these changes
Mar 25, 2024
Member
RoyStegeman
left a comment
There was a problem hiding this comment.
Other than the comment about the docs, the rest looks fine. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is innocuous since the theorydb utils just define which entries the theory accepts.
This will make it easier for other programs (e.g., pineko) to use theories from here. The global definition of the theory can be done in the
_TheoryCarddataclass. At the moment only the keys for NNPDF are there and they are all mandatory (even if it is not true).