Skip to content

Separate the theorydb utilities into the data package#2018

Merged
scarlehoff merged 2 commits into
masterfrom
separate_theory_into_data
Mar 25, 2024
Merged

Separate the theorydb utilities into the data package#2018
scarlehoff merged 2 commits into
masterfrom
separate_theory_into_data

Conversation

@scarlehoff
Copy link
Copy Markdown
Member

This is innocuous since the theorydb utils just define which entries the theory accepts.

This will make it easier for other programs (e.g., pineko) to use theories from here. The global definition of the theory can be done in the _TheoryCard dataclass. At the moment only the keys for NNPDF are there and they are all mandatory (even if it is not true).

@felixhekhorn
Copy link
Copy Markdown
Contributor

Do you want to do a further rename here theorydbutils -> theory?

@scarlehoff
Copy link
Copy Markdown
Member Author

No, at the moment externally these are just the utilities.
The proper theory.py can be born once someone creates the proper Theory class (at the moment there is a mock dataclass where I just declared all the fields that were in the sqlite database)

Comment thread doc/sphinx/source/data/data-config.rst
Copy link
Copy Markdown
Member

@RoyStegeman RoyStegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comment about the docs, the rest looks fine. Thanks!

@scarlehoff scarlehoff merged commit 8b9b29f into master Mar 25, 2024
@scarlehoff scarlehoff deleted the separate_theory_into_data branch March 25, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants