add y labels, integrate utils in filters and remove comma in sys names v2#2021
Merged
Conversation
RoyStegeman
reviewed
Mar 27, 2024
t7phy
force-pushed
the
multiple_fixes_v2
branch
from
05a7988 to
28658dd
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems there was an oversight on my part when opening #2020 that I hadn't noticed that nnpdf_data was already available as a standalone package that can be used while importing. This ofc allows (without any temporary breaking of filter files) to import utils from 1 place, as was agreed in CM. ATLAS_TTBAR_13TEV_HADR_DIF contains these utils and all the other ttb/jets/dis+j call whichever functions they need from here. This reduces code repetition and makes the review simpler.
To summarize:
sys,*are changed tosyst_*from validphys.commondata_utilsis replaced withfrom nnpdf_data.new_commondata.ATLAS_TTBAR_13TEV_HADR_DIF.utilsand I have explicitly checked rerunning the filters and they work.