fix std_error function in MCStats class#2036
Merged
Merged
Conversation
Member
|
Thanks. Let's see whether it has a visible effect anywhere. |
|
Greetings from your nice fit 🤖 !
Check the report carefully, and please buy me a ☕ , or better, a GPU 😉! |
Member
Author
|
Hmm, I would have expected to at least be able to see the difference with only 16 replicas |
Member
|
I'm surprised not many regressions failed. I guess the PDF errors are almost only used for the plots themselves so not many chances of having an effect. |
Member
Author
|
It's just because our code is optimally tested. One and only one test per functionality Yes... That's why.. |
scarlehoff
approved these changes
Apr 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1522 we replaced self.data with self.error_members(), but did not update the
ddofvalue accordingly.