Skip to content

Fixing bug in the MUL / ADD treatment when writing down closure data#2045

Merged
scarlehoff merged 5 commits into
masterfrom
2043-cholesky-decomposition-fails-for-atlas_2jet_7tev_r06-in-a-closure-test
Apr 11, 2024
Merged

Fixing bug in the MUL / ADD treatment when writing down closure data#2045
scarlehoff merged 5 commits into
masterfrom
2043-cholesky-decomposition-fails-for-atlas_2jet_7tev_r06-in-a-closure-test

Conversation

@andreab1997
Copy link
Copy Markdown
Contributor

@andreab1997 andreab1997 commented Apr 10, 2024

Solves #2043

@andreab1997 andreab1997 linked an issue Apr 10, 2024 that may be closed by this pull request
Cholesky decomposition fails for ATLAS_2JET_7TEV_R06 in a closure test #2043
Closed
scarlehoff
scarlehoff reviewed Apr 10, 2024
View reviewed changes
Comment thread validphys2/src/validphys/coredata.py Outdated
Comment thread validphys2/src/validphys/coredata.py Outdated
@RoyStegeman
Copy link
Copy Markdown
Member

RoyStegeman commented Apr 10, 2024

Please rebase

RoyStegeman
RoyStegeman reviewed Apr 10, 2024
View reviewed changes
Comment thread validphys2/src/validphys/coredata.py Outdated
@scarlehoff scarlehoff force-pushed the 2043-cholesky-decomposition-fails-for-atlas_2jet_7tev_r06-in-a-closure-test branch from d6939e1 to d489adf Compare April 10, 2024 14:57
@scarlehoff
Copy link
Copy Markdown
Member

scarlehoff commented Apr 10, 2024

I'm going to try adding also a test before merging since the solution is not really perfect

@RoyStegeman RoyStegeman changed the title Fixing but of cholesky decompositions in ATLAS_2JET_7TEV_R06 in a closure_test Fixing bug in cholesky decompositions of ATLAS_2JET_7TEV_R06 in a closure_test Apr 10, 2024
@RoyStegeman RoyStegeman added the bug Something isn't working label Apr 10, 2024
@scarlehoff
Copy link
Copy Markdown
Member

scarlehoff commented Apr 10, 2024

I did check that the test fails when the sorting is not applied.

@andreab1997
Copy link
Copy Markdown
Contributor Author

andreab1997 commented Apr 10, 2024

I did check that the test fails when the sorting is not applied.

Ok good thanks

@scarlehoff
Copy link
Copy Markdown
Member

scarlehoff commented Apr 11, 2024

Should we merge?

@andreab1997
Copy link
Copy Markdown
Contributor Author

andreab1997 commented Apr 11, 2024

Should we merge?

good for me

@scarlehoff scarlehoff merged commit b8e7ff2 into master Apr 11, 2024
@scarlehoff scarlehoff deleted the 2043-cholesky-decomposition-fails-for-atlas_2jet_7tev_r06-in-a-closure-test branch April 11, 2024 07:51
@scarlehoff scarlehoff changed the title Fixing bug in cholesky decompositions of ATLAS_2JET_7TEV_R06 in a closure_test Fixing bug in the MUL / ADD treatment when writing down closure data Apr 11, 2024
@scarlehoff scarlehoff mentioned this pull request May 20, 2024
Closed
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RoyStegeman RoyStegeman RoyStegeman left review comments

@scarlehoff scarlehoff scarlehoff approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cholesky decomposition fails for ATLAS_2JET_7TEV_R06 in a closure test

3 participants

@andreab1997 @RoyStegeman @scarlehoff