Skip to content

add nnpdf4.1 baseline theorycard#2048

Merged
andreab1997 merged 1 commit into
single_truthfrom
41_baseline_theory
Apr 22, 2024
Merged

add nnpdf4.1 baseline theorycard#2048
andreab1997 merged 1 commit into
single_truthfrom
41_baseline_theory

Conversation

@RoyStegeman
Copy link
Copy Markdown
Member

The parameters here should be in agreement with the theory as defined in #2028. Please have a look if there are any parameters that should be changed (or added/removed)

@RoyStegeman RoyStegeman changed the base branch from master to single_truth April 15, 2024 10:55
Comment thread validphys2/src/validphys/closuretest/multiclosure_pseudodata.py Outdated
Comment thread validphys2/src/validphys/tests/test_multiclosure.py Outdated
@scarlehoff
Copy link
Copy Markdown
Member

scarlehoff commented Apr 15, 2024

@RoyStegeman I think something went wrong because you got commits from master in here.

@RoyStegeman
Copy link
Copy Markdown
Member Author

RoyStegeman commented Apr 15, 2024

Oh lol, yes I put this on master but then the CI failed with an error about the keys in the theorydb so I moved it on top of single_truth. I couldn't really be bothered to remove the first two commits, and figured it was clear from the title and description of this PR that those were already in master. I guess it was not so obvious. Sorry...

@andreab1997 andreab1997 self-requested a review April 22, 2024 12:47
@andreab1997 andreab1997 merged commit 2a77e7c into single_truth Apr 22, 2024
@andreab1997 andreab1997 deleted the 41_baseline_theory branch April 22, 2024 12:53
@scarlehoff scarlehoff mentioned this pull request May 20, 2024
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants