Use results to create th uncertainties with pdf errors.#2051
Merged
Conversation
Member
|
Could you be more explicit in your explanation? What is the example nb trying to do that needs this? It seems that all this does is replace the exp covmat with an identity matrix, but I don't believe it is ever read anyway. Is it to save the computational resources? |
Member
Author
|
Ideally we want to get everything in validphys through a result object* but this creates a chicken-and-egg problem because the results object includes the covmat, so this adds as well a result obect without a covmat. *and the notebook is based on monkeypatching the results (and results_with_thcovmat) objects |
RoyStegeman
approved these changes
Apr 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary to allow for things like #2049 but in general it also cleans up the code as more things are concentrated under
results.@achiefa you will need to rebase on top of this branch if you want to add pdf errors but I think for the time being you don't need them so you can wait until it is in master.