fix table chi2 grouped by#2070
Merged
Merged
Conversation
7112b55 to
845b5d6
Compare
RoyStegeman
reviewed
May 8, 2024
Co-authored-by: Roy Stegeman <roystegeman@live.nl>
RoyStegeman
approved these changes
May 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the function
groups_chi2_table, the group information is being dropped. The list of chi2 is indeed grouped by the group you are interested in but thedatasetis saved as thegroupkey and the total-per-group is not being used.This is a fix to #1532 (which uses this function and which was the original bug)
Before:
Now: