add resample_pseudodata flag#2088
Merged
Merged
Conversation
scarlehoff
reviewed
May 22, 2024
Member
scarlehoff
left a comment
scarlehoff
left a comment
There was a problem hiding this comment.
I guess this will be a runcard parameter?
Could you add it either to docs or to some runcard example (even with the default value) just to signal that it exists.
Contributor
|
Just a question (maybe you already said and I do not remember): have you tried this with a MHOU fit? If yes, how much time does it take to get all pseudodata positive? |
Member
Author
|
This doesn't do any resampling and just accepts also negative xsecs |
scarlehoff
approved these changes
May 22, 2024
Co-authored-by: Juan M. Cruz-Martinez <juacrumar@lairen.eu>
RoyStegeman
force-pushed
the
add_resample_pseudodata_flag
branch
from
5e52129 to
8bc67b7
Compare
Contributor
Ok yes but I understood you did try the resampling no? |
Member
Author
|
Yes I did do MHOU fits with resampling (so the same as in master now), but I didn't track how much time that took |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For parameter fits it is important not to distort the pseudodata sampling distribution. This PR adds a flag
resample_negative_pseudodatathat can be set to False to also accept negative pseudodata values instead of resampling.