Fix new commondata filters#2100
Merged
Merged
Conversation
Member
Author
|
@comane what should be done about the following hard-coded paths? nnpdf/nnpdf_data/nnpdf_data/new_commondata/ATLAS_2JET_7TEV_R06/filter.py Lines 192 to 193 in 83f9af9 |
Member
|
Hi @Radonirinaunimi, I think that this is already taken care of in #2056 |
Member
Author
Ah, okok, thanks. I think it would then be better if that one is merged first. Do you want me to address the remaining comments there? |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does not attempt to polish the new commondata implementation, but simply to make sure that the filters run properly. The main purpose of this PR is to make #2099 works.
This has a minimal conflict with #2056, but that's something that can be solved easily.