Skip to content

Fix new commondata filters#2100

Merged
Radonirinaunimi merged 5 commits into
masterfrom
fixed-filters
Jun 19, 2024
Merged

Fix new commondata filters#2100
Radonirinaunimi merged 5 commits into
masterfrom
fixed-filters

Conversation

@Radonirinaunimi
Copy link
Copy Markdown
Member

This does not attempt to polish the new commondata implementation, but simply to make sure that the filters run properly. The main purpose of this PR is to make #2099 works.

This has a minimal conflict with #2056, but that's something that can be solved easily.

@Radonirinaunimi
Copy link
Copy Markdown
Member Author

@comane what should be done about the following hard-coded paths?

dat_file = '/Users/markcostantini/codes/nnpdfgit/nnpdf/buildmaster/results/DATA_ATLAS_2JET_7TEV_R06.dat'
sys_file = '/Users/markcostantini/codes/nnpdfgit/nnpdf/buildmaster/results/systypes/SYSTYPE_ATLAS_2JET_7TEV_R06_DEFAULT.dat'

@comane
Copy link
Copy Markdown
Member

comane commented Jun 5, 2024

Hi @Radonirinaunimi, I think that this is already taken care of in #2056

@Radonirinaunimi
Copy link
Copy Markdown
Member Author

Hi @Radonirinaunimi, I think that this is already taken care of in #2056

Ah, okok, thanks. I think it would then be better if that one is merged first. Do you want me to address the remaining comments there?

@Radonirinaunimi Radonirinaunimi requested a review from comane June 14, 2024 19:38
@Radonirinaunimi
Copy link
Copy Markdown
Member Author

@comane This should be ready to merged, now all the filters run, everything else could addressed in #2099.

@Radonirinaunimi Radonirinaunimi merged commit 5db544b into master Jun 19, 2024
@Radonirinaunimi Radonirinaunimi deleted the fixed-filters branch June 19, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants