Reimplement hera datasets#2175
Conversation
| import yaml | ||
|
|
||
| @dataclass | ||
| class commondata: |
There was a problem hiding this comment.
If the filters share similar or even identical parts, you can consider to place it in the filter_utils folder and store common parts there. For ex:
from nnpdf_data.filter_utils.hera import commondata
|
hi @peterkrack on top of the checks, make sure to change the process_type to one of these https://github.com/NNPDF/nnpdf/blob/master/validphys2/src/validphys/process_options.py (there should be some DIS types available) and change the kinematic files to use the variables listed there (which to 1st approximation means changing k1, k2, to x,Q or the other way around). You might need to change Q to Q2 in the kinematic files as well. |
…rtainties from systematics, moved class commondata to utils module.
…o make the tests pass.
|
Hi @peterkrack what is the status of this? |
|
Hi @peterkrack, sorry to bother you again, what is the status of this? |
|
Hi @peterkrack could you include in this PR data-theory comparisons and xq kinematic coverage plots? Thanks |
scarlehoff
left a comment
scarlehoff
left a comment
There was a problem hiding this comment.
Hi @peterkrack are you available this week to do the changes? Otherwise I'll do them so that we can merge this that has been stale for a few weeks now...
|
Plots with k2binsX in NC datasets are not a perfect match yet. |
|
Setting kinematics_override back to dis_sqrt_scale fixed the issue with the plots. |
peterkrack
left a comment
peterkrack
left a comment
There was a problem hiding this comment.
HERA reimplementation is ready for review.
|
@peterkrack are there any data theory comparisons for all the distributions implemented here? if not, can you please produce a report? |
|
HERA_CC_318GEV https://vp.nnpdf.science/UpTc36imQAW1_rQGtoarhA== |
| x: | ||
| description: Variable x | ||
| label: x | ||
| units: '' | ||
| k2: | ||
| description: Variable k2 | ||
| label: k2 | ||
| Q2: | ||
| description: Variable Q2 | ||
| label: Q2 | ||
| units: '' | ||
| k3: | ||
| description: Variable k3 | ||
| label: k3 | ||
| y: | ||
| description: Variable y | ||
| label: y |
There was a problem hiding this comment.
please update the description, label and units here.
|
Once the above comment is taken care of, this can be merged. |
4 participants
Added rawdata and filter.py script for HERA dataset.
Checks of reimplemented data are still missing.