Skip to content

Re-implementation of CMS single top#2200

Merged
scarlehoff merged 1 commit into
masterfrom
CMS-single-top-production
Nov 27, 2024
Merged

Re-implementation of CMS single top#2200
scarlehoff merged 1 commit into
masterfrom
CMS-single-top-production

Conversation

@jacoterh
Copy link
Copy Markdown
Collaborator

@jacoterh jacoterh commented Nov 7, 2024

This PR reimplements CMS single top. All datasets agree with the legacy implementation.

  • CMS_SINGLETOP_7TEV: no hepdata entry available. I manually checked legacy against the experimental paper and found perfect agreement.
  • CMS_SINGLETOP_8TEV: hepdata entry is available. Filter implemented and found perfect agreement. Validphys report this PR vs legacy.
obs = "TCHANNEL-XSEC"

new_implementation = f"CMS_SINGLETOP_8TEV_{obs}"
old_implementation = f"CMS_SINGLETOP_8TEV_{obs}"

inp1 = {
    "dataset_input": {"dataset": f"{new_implementation}"},
    "theoryid": 40_000_000,
    "use_cuts": "internal",
    "t0pdfset": "NNPDF40_nnlo_as_01180",
    "use_t0": True,
}
inp2 = {
    "dataset_input": {"dataset": f"{old_implementation}", "variant": "legacy"},
    "theoryid": 40_000_000,
    "use_cuts": "internal",
    "t0pdfset": "NNPDF40_nnlo_as_01180",
    "use_t0": True,
}

covmat1 = API.covmat_from_systematics(**inp1)
covmat2 = API.covmat_from_systematics(**inp2)

t0_covmat1 = API.t0_covmat_from_systematics(**inp1)
t0_covmat2 = API.t0_covmat_from_systematics(**inp2)

print(f"Comparison for {new_implementation}")
print(np.all(np.isclose(covmat1, covmat2)))
print(np.all(np.isclose(t0_covmat1, t0_covmat2)))

>>> Comparison for CMS_SINGLETOP_8TEV_TCHANNEL-XSEC
>>> True
>>> True
  • CMS_SINGLETOP_13TEV: no hepdata entry available. I manually checked legacy against the experimental paper and found perfect agreement.

All metadata has been updated accordingly.

@jacoterh jacoterh marked this pull request as ready for review November 8, 2024 12:00
@jacoterh
Copy link
Copy Markdown
Collaborator Author

Following up on @scarlehoff suggestion in PR#2185 to compare the overall experimental chi2 with all datasets combined, I'm attaching here the reports:

Regarding the ordering, for each dataset, legacy always appears first and is followed by the new commondata implementation.

Copy link
Copy Markdown
Member

@scarlehoff scarlehoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Please, bump the version number and change the version comment just like in the ATLAS one.

Although, I think you forgot to add some of the filter.py files?

(btw, like in the ATLAS pr, rebase on top of master please)

Comment thread nnpdf_data/nnpdf_data/commondata/CMS_SINGLETOP_13TEV/metadata.yaml Outdated
@@ -0,0 +1,33 @@
meta:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove this runcard from here (maybe put in the PR for reference)

(it will be eventually removed alongside all the rawdata anyway)

@scarlehoff scarlehoff added the Done PRs that are done but waiting on something else to merge/approve label Nov 12, 2024
@jacoterh jacoterh force-pushed the CMS-single-top-production branch from 8bfe593 to 3f4e62d Compare November 25, 2024 14:08
@jacoterh
Copy link
Copy Markdown
Collaborator Author

jacoterh commented Nov 25, 2024

Hi @scarlehoff , also this PR should be ready for merging once the tests pass. The reason some of the filter scripts aren't there is because there's no HEPdata entry for those datasets.

Final validphys report can be found at https://vp.nnpdf.science/2txronVJRuG9xBFIOjwPWQ==/

@scarlehoff scarlehoff force-pushed the CMS-single-top-production branch from 3f4e62d to 327ca7f Compare November 26, 2024 13:13
@scarlehoff scarlehoff merged commit b92e378 into master Nov 27, 2024
@scarlehoff scarlehoff deleted the CMS-single-top-production branch November 27, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data toolchain Done PRs that are done but waiting on something else to merge/approve

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants