Re-implementation of CMS single top#2200
Merged
Merged
Conversation
Collaborator
Author
|
Following up on @scarlehoff suggestion in PR#2185 to compare the overall experimental chi2 with all datasets combined, I'm attaching here the reports: Regarding the ordering, for each dataset, legacy always appears first and is followed by the new commondata implementation. |
scarlehoff
reviewed
Nov 12, 2024
| @@ -0,0 +1,33 @@ | |||
| meta: | |||
Member
There was a problem hiding this comment.
Please, remove this runcard from here (maybe put in the PR for reference)
(it will be eventually removed alongside all the rawdata anyway)
8bfe593 to
3f4e62d
Compare
Collaborator
Author
|
Hi @scarlehoff , also this PR should be ready for merging once the tests pass. The reason some of the filter scripts aren't there is because there's no HEPdata entry for those datasets. Final validphys report can be found at https://vp.nnpdf.science/2txronVJRuG9xBFIOjwPWQ==/ |
3f4e62d to
327ca7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reimplements CMS single top. All datasets agree with the legacy implementation.
All metadata has been updated accordingly.