Skip to content

Separated nnpdf data package#2225

Merged
scarlehoff merged 1 commit into
masterfrom
separate_nnpdf_data
Mar 5, 2025
Merged

Separated nnpdf data package#2225
scarlehoff merged 1 commit into
masterfrom
separate_nnpdf_data

Conversation

@scarlehoff
Copy link
Copy Markdown
Member

@scarlehoff scarlehoff commented Nov 23, 2024

This will remain a separate branch until the commondatas are all merged since merging this will create approx. one thousand conflicts.

Ready for review. Keeping this on top of master has not been my favourite thing to do, but I think I didn't break anything.

The package is available in pypi https://pypi.org/project/nnpdf-data/

@scarlehoff scarlehoff force-pushed the separate_nnpdf_data branch 5 times, most recently from a501ebf to c37ac13 Compare December 6, 2024 21:40
@scarlehoff scarlehoff force-pushed the separate_nnpdf_data branch 2 times, most recently from 870f376 to 5367ccf Compare January 13, 2025 10:16
@scarlehoff scarlehoff force-pushed the separate_nnpdf_data branch 2 times, most recently from ee40d83 to 17564a3 Compare January 29, 2025 07:52
@scarlehoff scarlehoff force-pushed the separate_nnpdf_data branch 2 times, most recently from ca6b1a1 to 9b02b11 Compare February 6, 2025 15:39
@scarlehoff scarlehoff marked this pull request as ready for review February 25, 2025 14:57
@scarlehoff
Copy link
Copy Markdown
Member Author

The code for this is now finished. Version 0.0.3 in pypi includes all data currently in master so it should be enough to reproduce 4.0', the alpha_s theories etc.

nnpdf_data is enough to read and inspect all commondata files (coredata.CommonData has been moved to nnpdf_data). It depends on both pandas and numpy but I think that's ok.

For the time being I will continue updating it by hand, but the goal would be for the CI to upload to pypi nnpdf (containing validphys and n3fit) and nnpdf_data (containing only the data) for every nnpdf tag, so that nnpdf_data and nnpdf are always synchronized for their versions.

Copy link
Copy Markdown
Member

@RoyStegeman RoyStegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

add utility function to read metadata just from dataset name

deprecate a bunch of functions

fix include
@RoyStegeman RoyStegeman force-pushed the separate_nnpdf_data branch from 91c3516 to 2d9fa66 Compare March 4, 2025 15:55
@scarlehoff scarlehoff merged commit a7e6184 into master Mar 5, 2025
@scarlehoff scarlehoff deleted the separate_nnpdf_data branch March 5, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants