implementation of CMS_WCHARM_7TEV in the new format#2245
Merged
Conversation
Contributor
Author
|
This PR is still WIP. Here you can find a report of the new implementation, which is preliminary: report
|
5 tasks
e4bf77e to
6a5cbb0
Compare
Contributor
Author
|
I have finalised the implementation of this dataset. Besides the new report posted in the description of this PR, I have the following comments:
Please, @RoyStegeman have a look at the implementation and let me know if you find something unclear or wrong. |
2ee81ed to
5bc8d02
Compare
49ceae7 to
5e91ceb
Compare
d64a8fe to
a4285c8
Compare
RoyStegeman
reviewed
Jan 12, 2025
Member
RoyStegeman
left a comment
There was a problem hiding this comment.
for both WPWM-RATIO and WPWM-TOT:
- The
legacyvariant gives exactly the same chi2 between master and this branch. - WPWM-RATIO: Difference between legacy and new implementation is minimal
- WPWM-TOT: Difference between legacy and new implementation is minimal
I still want to go over the code but if it's similar to the previous one I'm sure that will be fine
0ab7d87 to
bd47a55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments
This dataset delivers two different observables:
The variant
sys_10accounts for the 3pt prescription and thus it should be deprecated in the new format.Legacy: [default]
New: [default]