Skip to content

Reimplement ATLAS_Z0_7TEV_36PB Dataset#2250

Merged
scarlehoff merged 12 commits into
masterfrom
reimplement_ATLAS_Z0_7TEV_36PB
Jan 22, 2025
Merged

Reimplement ATLAS_Z0_7TEV_36PB Dataset#2250
scarlehoff merged 12 commits into
masterfrom
reimplement_ATLAS_Z0_7TEV_36PB

Conversation

@ecole41
Copy link
Copy Markdown
Collaborator

@ecole41 ecole41 commented Dec 18, 2024

Function have been added to produce data.yaml, kinematics.yaml and uncertainties.yaml files

Old vs New Data Report

https://vp.nnpdf.science/oEHnLzzYQu-glBEl0jRNbQ==/

Compatability Check

[In]:
from validphys.api import API
import numpy as np
 
inp1 = {"dataset_input": {"dataset": "ATLAS_Z0_7TEV_36PB_ETA"}, "theoryid": 40_000_000, "use_cuts": "internal", "t0pdfset": "NNPDF40_nnlo_as_01180", "use_t0": True}
inp2 = {"dataset_input": {"dataset": "ATLASZRAP36PB", "variant": "legacy"}, "theoryid": 40_000_000, "use_cuts": "internal", "t0pdfset": "NNPDF40_nnlo_as_01180", "use_t0": True}

covmat1 = API.covmat_from_systematics(**inp1)
covmat2 = API.covmat_from_systematics(**inp2)
 
t0_covmat1 = API.t0_covmat_from_systematics(**inp1)
t0_covmat2 = API.t0_covmat_from_systematics(**inp2)
 
result = np.all(np.isclose(covmat1, covmat2))
result_2 = np.all(np.isclose(t0_covmat1, t0_covmat2))

print('covmat', result)
print('t0_covmat', result_2)

[Out]:from validphys.api import API
import numpy as np
 
inp1 = {"dataset_input": {"dataset": "ATLASZRAP36PB"}, "theoryid": 40_000_000, "use_cuts": "internal", "t0pdfset": "NNPDF40_nnlo_as_01180", "use_t0": True}
inp2 = {"dataset_input": {"dataset": "ATLASZRAP36PB", "variant": "legacy"}, "theoryid": 40_000_000, "use_cuts": "internal", "t0pdfset": "NNPDF40_nnlo_as_01180", "use_t0": True}

covmat1 = API.covmat_from_systematics(**inp1)
covmat2 = API.covmat_from_systematics(**inp2)
 
t0_covmat1 = API.t0_covmat_from_systematics(**inp1)
t0_covmat2 = API.t0_covmat_from_systematics(**inp2)
 
result = np.all(np.isclose(covmat1, covmat2))
result_2 = np.all(np.isclose(t0_covmat1, t0_covmat2))

print('covmat', result)
print('t0_covmat', result_2)

Comment thread nnpdf_data/nnpdf_data/commondata/ATLAS_Z0_7TEV_36PB/metadata.yaml Outdated
@jacoterh
Copy link
Copy Markdown
Collaborator

@ecole41 same comment as #2223 also applies here: please redo the report with the updated conversion factor taken into account. Looks good otherwise!

Comment thread nnpdf_data/nnpdf_data/commondata/ATLAS_Z0_7TEV_36PB/metadata.yaml Outdated
Comment thread nnpdf_data/nnpdf_data/commondata/ATLAS_Z0_7TEV_36PB/metadata.yaml Outdated
@scarlehoff scarlehoff mentioned this pull request Jan 8, 2025
5 tasks
@ecole41 ecole41 changed the title [WIP] Reimplement ATLAS_Z0_7TEV_36PB Dataset Reimplement ATLAS_Z0_7TEV_36PB Dataset Jan 14, 2025
Copy link
Copy Markdown
Member

@scarlehoff scarlehoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just like in #2223, there's a factor of 10 missing in the luminosity uncertainty either in the new (*10) or in the old (1/10) data.

label: k1
abs_eta:
description: Absolute value of the rapidity of the Z boson
label: abs_eta
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
label: abs_eta
label: "$y$"

Since it is rapidity and not pseudorapidity better to use y. At some point we were using eta/y to automatize a bit things (you can change also the xlabel to $\left\| y\right|$ for instance) and so, some datasets that should be Y ended up being ETA. At some point I guess we'll update them.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just updated this

Comment thread nnpdf_data/nnpdf_data/commondata/ATLAS_Z0_7TEV_36PB/metadata.yaml Outdated
Co-authored-by: Juan M. Cruz-Martinez <juacrumar@lairen.eu>
@scarlehoff scarlehoff merged commit 6747c5d into master Jan 22, 2025
@scarlehoff scarlehoff deleted the reimplement_ATLAS_Z0_7TEV_36PB branch January 22, 2025 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants