Conversation
|
I think I'm done with this. Can you please check so that we can merge it into Jaco's PR? |
3bb2b7f to
56d001c
Compare
962e8fe to
4581109
Compare
|
I tested this and it works fine. Should I remove the hashing of the theorycovamat? |
Yes, since we are not going to recompute the theorycovmat when running n3fit. |
|
Hi @scarlehoff, I've implemented your suggestions. Let me know. |
|
I think you can rebase only the md5 part on top of master (instead of pointing to |
|
Yes, I agree. I've reversed the changes inherited from Edit: let me rebase on top of master before |
|
Rebased on top of master |
|
I've updated the tests, and the documentation as well. The tests are now running. Can you please check if this is what you had in mind? |
scarlehoff
left a comment
There was a problem hiding this comment.
Thanks! And thanks for updating the docs as well.
This PR should address #2461. Please have a look.
Also, I was wondering whether we want to hash also the files in
filterdirectory. This would be an easy fix.