Conversation
Fix bug where we would get that the cuts are different if a mask with
all the data had been written for one of the fits and not for the other.
For example, this would report that the cuts are different:
```
use_cuts: fromfit
fits:
- 190310-tg-nlo-DIS
- 181126-si-nlo-central_DISonly
template_text: |
{@print_different_cuts@}
actions_:
- report(main=True)
```
even if they aren't. The reason why this bug existed in the first place
was the willingness to avoid loading datasets just to check the actual
number of datapoints, given that that is expensive. That has been worked
around since.
Contributor
Author
|
@scarrazza can you look at this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug where we would get that the cuts are different if a mask with
all the data had been written for one of the fits and not for the other.
For example, this would report that the cuts are different:
even if they aren't. The reason why this bug existed in the first place
was the willingness to avoid loading datasets just to check the actual
number of datapoints, given that that is expensive. That has been worked
around since.