Fixing next effective exponents table

[siranipour]

Closes #730

[wilsonmr]

does that look like it's working to you? I think it looks ok for me - basically there was no need to use the internal table since we don't even care abou the previous exponents for this action and I seperated the two tables in #684 and so it just makes sense to use that

[siranipour]

does that look like it's working to you? I think it looks ok for me - basically there was no need to use the internal table since we don't even care abou the previous exponents for this action and I seperated the two tables in #684 and so it just makes sense to use that

Yep the last commit looks good to me!

[wilsonmr]

cool, if you could add a test that'd be good, I'm not sure if the tests already use a fit, I have some low replica dis only closure tests which will produce potentially garbage numbers but will be quick to download 191015-mw-001 is one, might be sufficient to make a table comp to check the values are the same each time etc.

[wilsonmr]

or if you know of another low replica fit

[siranipour]

I've added a quick test to ensure the ite2 runcard predicted by vp matches the one I just generated using 191015-mw-001 as a dummy ite1

[Zaharid]

Looks fine. But I wonder if we can afford to download two fits in the CI....

[siranipour]

Yeah I was wondering this, but the 2nd fit is empty in the sense that it doesn't have any replicas in it, so it's as lightweight as possible

[Zaharid]

Looks fine. Thanks!