Conversation
wilsonmr
approved these changes
May 6, 2020
Contributor
wilsonmr
left a comment
wilsonmr
left a comment
There was a problem hiding this comment.
looks fine!
I wonder how hard it would be to make an App which lists available resources? probably leveraging the downloadable* function in loader
nnpdf/validphys2/src/validphys/loader.py
Line 711 in cb07006
I guess we can save that for another time
tgiani
approved these changes
May 6, 2020
Contributor
Author
|
Thanks for checking this! I'll merge and then take a look at #764 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple PR that closes one of the items on #656. I've also fixed one thing in the doc headings that was annoying me