kinetic transformations for dijets#758
Merged
Merged
Conversation
Zaharid
reviewed
May 4, 2020
| TODO: NB!! HARDCODING sqrt(s) = 8 TeV, the c.m. energy of 1705.02628.pdf | ||
| plotting both x1 and x2 | ||
| """ | ||
| sqrts = 8000 |
Contributor
There was a problem hiding this comment.
@enocera how bad is it to hardcode this in here? Maybe we could put it in the PLOTTING files instead?
Contributor
There was a problem hiding this comment.
I'm undecided, frankly. The only risk I see is that we forget that sqrts has been hardcoded here. Specifying it in the PLOTTING files should possibly avoid this risk. On the other hand, it's also true that the class has a specific name (which could be made even more specific like DIJETCMS3D8TEVXQ2MapMixin, or something similar, if you understand what I mean). This should prevent any confusion in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start implementing the changes discussed here #756