Skip to content

create a .version file per replica #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scarrazza merged 2 commits into from
May 27, 2020
Merged

create a .version file per replica #786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9e75ec
create a .version file per replica
scarlehoff May 26, 2020
4db94a7
change name to version.info
scarlehoff May 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions n3fit/src/n3fit/io/writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import json
import numpy as np
from reportengine.compat import yaml
import n3fit
from n3fit.msr import compute_arclength


Expand Down Expand Up @@ -241,3 +242,7 @@ def storefit(
# create .time file
with open(f"{replica_path}/{fitname}.time", "w") as fs:
json.dump(timings, fs, indent=2)

# create .version file
with open(f"{replica_path}/version.info", "w") as fs:
fs.write(n3fit.__version__)
6 changes: 6 additions & 0 deletions n3fit/src/n3fit/tests/test_fit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
from collections import namedtuple
from numpy.testing import assert_almost_equal
from reportengine.compat import yaml
import n3fit
from n3fit.performfit import initialize_seeds

log = logging.getLogger(__name__)
Expand Down Expand Up @@ -103,6 +104,11 @@ def test_performfit():
fitting_time = times["walltime"]["replica_set_to_replica_fitted"]
f.close()
assert fitting_time < EXPECTED_MAX_FITTIME
version_path = tmp_path / f"{QUICKNAME}/nnfit/replica_{REPLICA}/version.info"
f = open(version_path, "r")
version = f.read()
f.close()
assert version == n3fit.__version__


def test_hyperopt():
Expand Down