Expose the luminosity and bin mask options for FKs to the python interface#273
Merged
Conversation
Contributor
|
This looks good to me. It would be perfect if you could also add a small test. |
alecandido
reviewed
Apr 16, 2024
Collaborator
|
I'm working on fixing the signature. Of course, you could drop the last commit and merge, but I believe to be valuable to avoid some overhead (whenever possible). |
Member
Author
|
As you wish, since you are at it please add also the test that @cschwan asked for. |
alecandido
force-pushed
the
expose_more_options_fkpython
branch
from
3f2fbf9 to
9bace31
Compare
felixhekhorn
changed the title
Member
Author
|
Thanks @alecandido As a note for the future, we should add maybe a test that does the entire |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems to work. I've just copied it from the grid.