Update Python docs#301
Conversation
Radonirinaunimi
left a comment
There was a problem hiding this comment.
Thanks for this @felixhekhorn.
I will have a detailed look as soon as possible but I've picked up very tiny typos while I was skimming through.
Are you also planning to modify the occurrences of lumi(_) in the argument of the functions and in the variables names of src/fk_table.rs, src/grid.rs, and pineappl/grid.py?
|
#157 is a related Issue. |
Co-authored-by: Tanjona Rabemananjara <rrabeman@nikhef.nl>
I hope I caught all remaining occurrences - the only remaining appearance of the word "lumi" in There is some overlap with #302 since both are touching the files in |
|
I ran |
|
I can merge this now if you like, for wrappers of When this will be merged into |
looks good
indeed, I know that the |
|
We need a strategy for merging this, since #302 removes all Python files and thus the changed documentation. So either I
@felixhekhorn @Radonirinaunimi what path do you believe is best? |
I'm in favour of option 1:
if we can resolve #302 quickly they can go into one version (as both are breaking) |
Closes #157
This mostly updates and fixes all Python doc strings.
Apart from that there are few more (even breaking) changes:
PyGrid::evolvegot deprecated (as the underlying function)PyFkTable::convolve_with_two: return type was harmonized withPyFkTable::convolve_with_oneto avoid the deprecation ofinto_pyarrayif necessary we could also add other changes to the Python interface here, such as to expose
Grid::convolutions