Skip to content

v0.7.x#305

Closed
cschwan wants to merge 7 commits into
masterfrom
v0.7.x
Closed

v0.7.x#305
cschwan wants to merge 7 commits into
masterfrom
v0.7.x

Conversation

@cschwan
Copy link
Copy Markdown
Contributor

@cschwan cschwan commented Aug 30, 2024

This is the patch branch for versions 0.7.x. Do not merge this branch into master!

@cschwan cschwan self-assigned this Aug 30, 2024
@felixhekhorn
Copy link
Copy Markdown
Contributor

let me repeat again what I was asking in #308


also note that in v0.7.4 the error is slightly different:

return self.raw.convolute_with_two(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: argument 'bin_indices': type mismatch:
 from=int64, to=uint64

do we want to keep fixing former version, or not?

@cschwan
Copy link
Copy Markdown
Contributor Author

cschwan commented Sep 3, 2024

I'm not sure I understand this: is 0.7.x broken in any way?

@felixhekhorn
Copy link
Copy Markdown
Contributor

I'm not sure I understand this: is 0.7.x broken in any way?

the bin_indices argument of convolute_with_* is (or seems to be) broken - but broken in a different way then master #308

@cschwan
Copy link
Copy Markdown
Contributor Author

cschwan commented Sep 5, 2024

I wouldn't say it's broken, it's just (from the POV of Python) unexpectedly strict. You must pass a numpy array and the types must be unsigned integers. I suppose that really is unnecessarily strict, and we should allow more flexibility. However, this would probably be a breaking change, so let's not change anything for 0.7.x.

@cschwan
Copy link
Copy Markdown
Contributor Author

cschwan commented Oct 4, 2024

This branch is outdated; before we make another 0.7.x release, we should first merge the following commits (probably):

  1. e6a2dea
  2. 49e1c08
  3. a3a0804
  4. 76a1e89

@cschwan
Copy link
Copy Markdown
Contributor Author

cschwan commented Aug 12, 2025

We will no longer support v0.7, so I'm closing this PR.

@cschwan cschwan closed this Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants